Repository navigation
fix(agent): fold large unchanged subtrees in the full-screen fallback #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Varshith-Kali
wants to merge
12
commits into
e2e-inc:main
Choose a base branch
from
Varshith-Kali:fix-1788-mcp-fold-unchanged-subtrees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,306
−63
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3b15e6c
fix(agent): fold large unchanged subtrees in the full-screen fallback…
Varshith-Kali 81681e4
fix(changeset): restore missing opening frontmatter delimiter
Varshith-Kali 91ed3b9
fix(agent): name the last full listing in fold lines and keep it thro…
Varshith-Kali b9ff882
fix(plugins): sync generated skill reference with fold-line wording
Varshith-Kali a30b6fd
fix(agent): clear fold records on truncated renders and drop the redu…
Varshith-Kali 8db7cbb
test(agent): make the kept-screens budget test discriminate
Varshith-Kali 8014923
fix(agent): clear fold records on overflow shrink and cover the text-…
Varshith-Kali b864b97
fix(agent): share one screen presenter per step and forget its folds …
Varshith-Kali 68b12ab
docs(agent): correct the screen option doc to name the shared presenter
Varshith-Kali bcd42e9
fix(agent): bind a fresh screen presenter per loop run
Varshith-Kali 7a72306
fix(agent): restore the previous screen presenter when a loop run ends
Varshith-Kali eb3d233
fix(agent): stack screen presenters per loop run so concurrent runs l…
Varshith-Kali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "e2e": patch | ||
| --- | ||
|
|
||
| When an action changes most of the screen, large subtrees that did not change are shown as one line instead of being repeated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The reordering that keeps an overlapping run's opening prompt on its own presenter has no regression test. The concurrent-run test uses custom
buildPromptfunctions, so the built-in act loop'sbuildPromptis never exercised with two overlapping runs. Add a test with twocreateBuiltInAgentruns on one context whoseobserveresolves at different times, and check each opening prompt.Prompt for AI agents