Repository navigation
Conversation
There was a problem hiding this comment.
No issues found across 6 files
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
okwasniewski
left a comment
There was a problem hiding this comment.
[claude-opus-5-5] automated review on behalf of @okwasniewski
Thanks! Shape matches the issue: scheduler owns the count, a worker with a counted failure waits for continue or interrupt, no timer, no extra round-trip without a limit. No deadlock found (every result reaches the reply, the stop path always broadcasts interrupt), retries only count the final result, serial groups and shards behave, runner and worker are always the same version. New test fails 3/3 on main and passes 7/7 here; the issue repro now ends 2 failed + failure-limit skips.
Must fix:
packages/e2e/tests/integration/parallel-workers.test.ts:805- nothing fast coverscontinue. Dropping thecontinuereply keeps the new test green (the second failure's interrupt releases the first worker); onlyrunner-lifecyclecatches it, by hanging to its 120 s timeout. A lostcontinuehangs the run forever. Add a 2-worker case below the limit (e.g.maxFailures: 3, both files fail once) asserting bothnexttests pass. Optional: ascheduler.test.tsunit for continue-below-limit / none-at-limit.packages/e2e/src/run/worker/session.ts:324- theawait this.failuresAnswered()in the setup loop is dead: a setup unit holds one setup pair and the count is 0 when a unit starts. If it ever did gate after an interrupt,runSetupUnithas no interrupt check and would reportfailedwith 0 attempts. Drop it and keep the single gate in the executor..changeset/max-failures-worker-wait.md:6- second sentence is internals. Keep only the user-facing first sentence.
Nits:
scheduler.ts:928-933repeatscountsTowardFailureLimitnext toreport(). Havereport()return whether the run continues and answer from that; the 3-line comment goes away.execute.ts:140-145-beforePairJSDoc describes the worker/runner protocol; keep it to "awaited before each pair starts, before the interrupt check".session.ts:225-Math.max(0, unanswered - 1)hides an unasked-forcontinue; a plain decrement is fine.protocol.ts:95-failureLimitas a boolean reads like a number; e.g.answersFailures.- New test picks the tripping file by attempt end time; a short note on why the 500 ms gap exists helps.
|
Thanks for the careful review. All fixed in 60737c3: Must fix
Nits
Unit 3654 passed, integration 976 passed, and |
There was a problem hiding this comment.
0 issues found across 7 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
[claude-opus-5-5] automated review on behalf of @okwasniewski Re-reviewed at 60737c3. All asks are done:
One question: Labeling Ready for Human Review. The two open questions from the first review, about bounding how long a waiting worker can wait and about how setup after an interrupt is reported, are for a maintainer. |
|
Reverted in 616c401: the four tests (blocked-worker, blocked-retry, watchdog-window, serial-member) are back to 60 s. I had no good reason for raising them; they aren't affected by this change. |
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
[claude-opus-5-5] automated review on behalf of @okwasniewski Re-checked at 616c401. The only change is the revert of the four 120 s timeouts back to 60 s in |
616c401 to
517ecc6
Compare
517ecc6 to
5516411
Compare
|
Rebased on main after #1736. The only conflict was in |
What and why
RunUnitMessage.failureLimitis just a flag that the run has a limit; the snapshot ({ limit, failures }) and the worker's owncountFailurearithmetic are gone.TargetExecutorOptions.beforePair, also before each setup pair) until the runner answers. The answer is a newcontinuemessage when the run is still below the limit, or the existinginterruptwith thefailure-limitskip once it is reached. One round-trip per failure, no timing.emit.e2e. No docs change:docs/reference/cli.mdxalready describes the fixed behavior.Issue
Fixes #1745
Verified
Ran it locally: yes
maxFailures: 2test inparallel-workers.test.ts: fileafails at once, filebfails 500 ms later, sob's worker trips the limit. It asserts the rest of the tripping file is skipped withfailure-limit(nointerrupted), and at most oneinterruptedoverall. It fails 3 of 3 runs against amainbuild and passes 5 of 5 here.b nextinterrupted(started after the limit, then cancelled)b nextandb lastskipped,failure-limitvitest run tests/unit: 3653 pass.vitest run tests/integration: 972 pass, 3 fail incli-init.test.tsonly because@e2e-dev/mobilewas not built locally (same onmain).pnpm checkgreen.Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.!, the changeset body names what breaks and what replaces it, and the deprecation warning landed a window earlier (stability policy in CONTRIBUTING.md).docs/**/*.mdxpage for the behavior, andskills/e2e/if the skill describes it..d.tsreviewed,tests/types/sdk-types.tsupdated; wire change edits the schema and both fixtures.e2e/engine): changesets fore2e,@e2e-dev/web, and@e2e-dev/mobile.