Repository navigation
fix(web): check an sr-only checkbox or radio through its own label #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhinavapasok
wants to merge
3
commits into
e2e-inc:main
Choose a base branch
from
abhinavapasok:fix/web-sr-only-label-stand-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+165
−30
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
7508e88
fix(web): check an sr-only checkbox or radio through its own label
abhinavapasok b547a67
docs(changeset): say uncheck still refuses a native radio
abhinavapasok 31f03bc
fix(web): pick the label when the control misses a hit at its own centre
abhinavapasok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@e2e-dev/web": patch | ||
| --- | ||
|
|
||
| `check`, `uncheck`, and `tap` click a checkbox or radio that `sr-only` or `visually-hidden` clips, the usual toggle-switch markup, through its own label instead of failing with `intercepts pointer events`. `uncheck` still refuses a native radio without clicking it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The pixel fallback accepts a label whose center lands on an ARIA checkbox, radio, or switch because
INTERACTIVEomits those roles. Extend the interactive-control check so this path refuses those targets rather than clicking them.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INTERACTIVEis the selector every label stand-in path on main already uses (the boxless control and the hit at the control point), not something this PR adds. Adding the ARIA checkbox, radio, and switch roles would change those paths for Element Plus and boxless controls too, so I have left it out of this fix. Happy to send it as a follow-up if you want it.