Skip to content

refactor: move e2e's core into @e2e-dev/core, and engines peer on it - #1737

Merged
okwasniewski merged 4 commits into
mainfrom
kdy1/e2e-core-2-move
Nov 15, 2026
Merged

okwasniewski merged 4 commits into
mainfrom
kdy1/e2e-core-2-move

Conversation

@kdy1

@kdy1 kdy1 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Stack 2/3: session-half split → this PR → @e2e-dev/core API.

2026-11-15: rebased onto main 235986078 and the package renamed from e2e-core to @e2e-dev/core. Command output quoted below predates the rename.

Moves the engine contract, locators, agent, replay cache, secrets, and the session half of a worker from packages/e2e to packages/core, published as the new @e2e-dev/core package. e2e is built on it. Nothing changes in behavior.

flowchart BT
  core["@e2e-dev/core<br/>engine contract, locators, agent, cache,<br/>secrets, engine sessions, standalone worker"]
  e2e["e2e<br/>CLI, collector, scheduler, reporters, expect, MCP"]
  web["@e2e-dev/web, @e2e-dev/mobile"]
  e2e -- "dependency, exact version (fixed group)" --> core
  web -- "peer" --> core
  web -- "peer" --> e2e
Loading
  • @e2e-dev/core: 145 modules moved with git mv to the same paths under packages/core/src. Its one public entry is @e2e-dev/core/engine. e2e reaches the rest as @e2e-dev/core/lib/<path> (./lib/* in its exports), which is not public API. The next PR adds the @e2e-dev/core and @e2e-dev/core/agent entries.
  • e2e: depends on @e2e-dev/core at its exact version (workspace:*), and the changesets fixed group keeps the two versions equal. e2e/engine and e2e/agent re-export it unchanged, so engines, integrations, and executors work as before.
  • Engines: @e2e-dev/web and @e2e-dev/mobile import @e2e-dev/core/engine and peer on @e2e-dev/core beside e2e (>=0.23.1 <1).
  • Yarn: Yarn installs no peer the project does not list, and under Plug'n'Play the engine then fails to load. e2e init adds @e2e-dev/core beside an engine, and e2e upgrade adds a required @e2e-dev/* peer the project lacks, at the version e2e depends on. Checked on Yarn 4.18.1 PnP with packed builds: without core listed the config fails to load, with it the scaffolded test passes.
  • CI:
    • The root build and test scripts run @e2e-dev/core first, and so does the Bun job in spec.yml.
    • .github/filters.yml adds packages/core/** to the runner filter.
    • The nightly examples workflow packs @e2e-dev/core and overrides it in each example's npm install.
    • scripts/install-smoke.ts packs it too and fails on a second installed copy.

Most of the diff is mechanical: of 639 files, 145 are pure renames and most of the rest only rewrite import specifiers to @e2e-dev/core/lib/<path>. The parts to read:

What Where
package manifests packages/core/package.json, packages/e2e/package.json, packages/{web,mobile}/package.json, root package.json, .changeset/config.json
the moved entries and their stubs packages/core/src/engine/index.ts and agent/public.ts (verbatim), packages/e2e/src/engine/index.ts and agent/public.ts (re-exports)
build and test config packages/core/tsconfig*.json, packages/core/vitest.config.ts, packages/e2e/vitest.config.ts (the integration project externalizes core's dist, so tests and the built runner share one module state)
guards packages/e2e/tests/unit/package-imports.test.ts (follows imports into @e2e-dev/core; ai stays lazy there), scripts/install-smoke.ts, scripts/check-error-codes.ts
CI .github/workflows/spec.yml, examples.yml, .github/actions/example-packages/action.yml, .github/filters.yml, CODEOWNERS
prose AGENTS.md, CONTRIBUTING.md (stability, engine contract), docs/writing-an-engine.mdx, docs/reference/engine.mdx, READMEs

To confirm the rest is only import lines: git diff -M --unified=0 <base> <head> -- 'packages/*/src' 'packages/*/tests' | grep '^[-+][^-+]' | grep -v "from '\|import('".

Before merging: @e2e-dev/core does not exist on npm yet, and npm Trusted Publishing can only be added to a package that exists. Publish a placeholder @e2e-dev/core@0.0.0 by hand and connect release.yml as its trusted publisher (CONTRIBUTING.md, "npm Trusted Publishing") before this merges. Otherwise the next release publishes e2e with an exact dependency on an @e2e-dev/core version that failed to publish.

Verified

Ran it locally: yes. No behavior changes, so the evidence is the existing suites against the built packages, plus a fresh install:

  • pnpm test: e2e 4626 passed (unit and integration), web 810, mobile 531, every other package green, and @e2e-dev/core's entries check.
  • Testbed through the built CLI: 588 passed, 1 skipped.
  • scripts/install-smoke.ts with pnpm 11 and pnpm 12: installs the packed @e2e-dev/core, e2e, @e2e-dev/web, and @e2e-dev/mobile with no build scripts, finds one @e2e-dev/core copy, typechecks a mobile tool, and runs a TypeScript test.
  • pnpm check passes.
  • Not run locally: the nightly examples workflow's npm override of @e2e-dev/core. It only runs on the nightly or on a manual dispatch, which posts to Slack.

🤖 Generated with Claude Code

@kdy1
kdy1 requested a review from okwasniewski as a code owner November 13, 2026 06:58
@github-actions github-actions Bot added the size:XXL 1,000+ changed lines, not counting tests, fixtures, or the lockfile label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e web: 93 passed

All 93 tests in 42 files
Test Time
🟢 tests/aria-hidden-flow.e2e.ts · 2 passed 590ms
🟢 aria hidden flow › picks the Pro plan by its visible text and confirms it 440ms
🟢 aria hidden flow › another plan shows the error and keeps the picker open 150ms
🟢 tests/async-states.e2e.ts · 2 passed 7.0s
🟢 async states › reads the code off the transient toast and verifies it once the button enables 2.3s
🟢 async states › a wrong code is rejected after the toast has gone 4.8s
🟢 tests/canvas-only.e2e.ts · 2 passed 242ms
🟢 canvas only › taps square, circle, then diamond at their pixel coordinates 124ms
🟢 canvas only › a shape out of order paints the error and resets progress 118ms
🟢 tests/canvas-whiteboard.e2e.ts · 2 passed 363ms
🟢 canvas whiteboard › drags both shapes into their slots and saves 226ms
🟢 canvas whiteboard › bounces a shape off the wrong slot and refuses to save early 137ms
🟢 tests/cart-totals.e2e.ts · 2 passed 322ms
🟢 cart totals › increasing a quantity updates the line total but the order summary stays stale (planted bug) 186ms
🟢 cart totals › a quantity never drops below one 136ms
🟢 tests/checkout-review.e2e.ts · 1 passed 165ms
🟢 shows a raw greeting token and an undefined delivery date (planted bug), yet places the order 165ms
🟢 tests/context-menu-trap.e2e.ts · 2 passed 496ms
🟢 context menu trap › right-click opens nothing; the row menu renames the file 267ms
🟢 context menu trap › the decoy menu items refuse and keep the file 229ms
🟢 tests/control-inventory.e2e.ts · 8 passed 3.4s
🟢 control inventory › check sets the checkbox and the radio without flipping a set one 234ms
🟢 control inventory › check picks a radio the pick replaces with its summary 138ms
🟢 control inventory › a long press and a double click are told apart from a tap 995ms
🟢 control inventory › the file menu opens on right-click only and Rename renames the file 217ms
🟢 control inventory › setInputFiles attaches files named from the project root 124ms
🟢 control inventory › the details view is left through the browser history 152ms
🟢 control inventory › scrollIntoView brings the footnote into view 242ms
🟢 control inventory › every exercise done shows the success message 1.3s
🟢 tests/css-content-ui.e2e.ts · 2 passed 279ms
🟢 css content ui › the tile labelled Ship it advances and confirming ships 159ms
🟢 css content ui › a wrong tile shows the CSS-rendered error and keeps the picker 120ms
🟢 tests/date-picker.e2e.ts · 2 passed 547ms
🟢 date picker › navigates three months ahead and books the required date 314ms
🟢 date picker › confirming without the exact date shows the error 233ms
🟢 tests/debounced-search.e2e.ts · 2 passed 2.8s
🟢 debounced search › a decoy one character off is refused 1.4s
🟢 debounced search › picking the exact item adds it to the cart 1.4s
🟢 tests/deferred-dialog.e2e.ts · 1 passed 1.1s
🟢 one submit opens one confirm, even when double-clicked 1.1s
🟢 tests/div-soup.e2e.ts · 2 passed 590ms
🟢 div soup › a wrong code is rejected 257ms
🟢 div soup › the right code grants access after the delete tile fixes a typo 333ms
🟢 tests/drag-and-drop.e2e.ts · 2 passed 599ms
🟢 drag and drop › an out-of-order item resets the dropzone 299ms
🟢 drag and drop › dropping Banana then Cherry passes 300ms
🟢 tests/filter-deep-link.e2e.ts · 2 passed 193ms
🟢 filter deep link › filtering writes the query to the URL 111ms
🟢 filter deep link › opening a shared link restores the filter 82ms
🟢 tests/gift-card-purchase.e2e.ts · 3 passed 470ms
🟢 gift card purchase › refuses to buy without an amount 120ms
🟢 gift card purchase › refuses a recipient without an at sign 164ms
🟢 gift card purchase › sends the gift card 186ms
🟢 tests/hover-menu.e2e.ts · 2 passed 417ms
🟢 hover menu › a decoy leaf is refused 182ms
🟢 hover menu › hovering Account, then Billing, reaches Redeem voucher 235ms
🟢 tests/iframe-form.e2e.ts · 2 passed 509ms
🟢 iframe form › a wrong code is refused by the host page 251ms
🟢 iframe form › the code read from one frame applies through the other 258ms
🟢 tests/image-only-ui.e2e.ts · 3 passed 401ms
🟢 image only ui › the icons have no names, so the bare svg locator is ambiguous 101ms
🟢 image only ui › a wrong icon shows the error image and keeps the icons 133ms
🟢 image only ui › tapping the star, then the heart, verifies the icons 167ms
🟢 tests/infinite-scroll.e2e.ts · 1 passed 2.6s
🟢 scrolls the feed until the Golden Ticket loads, then claims it 2.6s
🟢 tests/kanban-board.e2e.ts · 3 passed 671ms
🟢 kanban board › pointer drags move both cards into the goal layout 337ms
🟢 kanban board › a swipe along a path drags a card as well 133ms
🟢 kanban board › a plain tap moves nothing and the untouched board is rejected 201ms
🟢 tests/login-form.e2e.ts · 4 passed 713ms
🟢 login form › rejects a malformed email 166ms
🟢 login form › rejects a short password 166ms
🟢 login form › rejects an unknown account 184ms
🟢 login form › signs in and logs out 197ms
🟢 tests/lying-labels.e2e.ts · 4 passed 598ms
🟢 lying labels › the button whose accessible name says Pay now is the wrong one 135ms
🟢 lying labels › a text match for Pay now catches the decoy phrase too 91ms
🟢 lying labels › the field whose accessible name says Amount is the wrong one 172ms
🟢 lying labels › visible text drives the payment through 200ms
🟢 tests/native-dialogs.e2e.ts · 3 passed 399ms
🟢 native dialogs › answers the confirm, prompt, and alert chain 135ms
🟢 native dialogs › dismissing the confirm cancels the order 133ms
🟢 native dialogs › a wrong gift code is rejected 131ms
🟢 tests/new-tab-flow.e2e.ts · 2 passed 382ms
🟢 new tab flow › reads the code in the tab the app opens and enters it back in the original tab 196ms
🟢 new tab flow › a tap that opens a tab leaves the screen on the original tab, and activate shows the new one 186ms
🟢 tests/newsletter-signup.e2e.ts · 1 passed 2.2s
🟢 subscribe renders no feedback and logs a TypeError (planted bug) 2.2s
🟢 tests/onboarding-wizard.e2e.ts · 5 passed 4.4s
🟢 onboarding wizard › back keeps what was typed and the brief comes back with it 261ms
🟢 onboarding wizard › the address step takes the brief through its bare-div dropdown 314ms
🟢 onboarding wizard › the profile step steers the calendar three decades back 1.1s
🟢 onboarding wizard › the preferences step flips the toggles the brief names and leaves the trap off 1.3s
🟢 onboarding wizard › the review step repeats the brief and finishes with the PIN 1.4s
🟢 tests/order-history.e2e.ts · 2 passed 1.4s
🟢 order history › overview and settings render their panels 180ms
🟢 order history › the orders tab never leaves its loading state (planted bug) 1.3s
🟢 tests/otp-auto-advance.e2e.ts · 3 passed 1.4s
🟢 otp auto-advance › focus advances with each digit and the full code verifies 473ms
🟢 otp auto-advance › backspace on an empty box clears and refocuses the previous one 138ms
🟢 otp auto-advance › a wrong code clears every box and starts over 779ms
🟢 tests/overlay-trap.e2e.ts · 1 passed 696ms
🟢 continues only after the banner and the overlay are gone 696ms
🟢 tests/playbook-cleanup.e2e.ts · 2 passed 530ms
🟢 playbook cleanup › deleting the draft removes it from an exact-name search 250ms
🟢 playbook cleanup › cancelling the dialog keeps the draft searchable 280ms
🟢 tests/price-sorting.e2e.ts · 3 passed 421ms
🟢 price sorting › opens in the featured order with sale prices struck through 119ms
🟢 price sorting › low to high sorts by the original price, not the paid one (planted bug) 163ms
🟢 price sorting › high to low is the same wrong order reversed (planted bug) 139ms
🟢 tests/product-reviews.e2e.ts · 1 passed 1.2s
🟢 the running-shoe page lists coffee-grinder reviews (planted bug) 1.2s
🟢 tests/promo-storefront.e2e.ts · 1 passed 1.4s
🟢 buys a deal once the promo chrome is out of the way 1.4s
🟢 tests/rich-text-editor.e2e.ts · 2 passed 434ms
🟢 rich text editor › bolding exactly the required word passes the check 215ms
🟢 rich text editor › bold that spills into the previous word fails the check 219ms
🟢 tests/saved-addresses.e2e.ts · 3 passed 513ms
🟢 saved addresses › adds an address and clears the form 167ms
🟢 saved addresses › ignores an add with an empty field 162ms
🟢 saved addresses › delete shows its toast but keeps the address, on retry too (planted bug) 184ms
🟢 tests/shadow-dom-form.e2e.ts · 2 passed 532ms
🟢 shadow DOM form › rejects a wrong access code 265ms
🟢 shadow DOM form › grants access with the code from the hint inside the root 267ms
🟢 tests/smoke.e2e.ts · 1 passed 345ms
🟢 home lists the scenarios and opens one 345ms
🟢 tests/stale-dom.e2e.ts · 1 passed 2.1s
🟢 taps the moving target three times across rebuilds of the list 2.1s
🟢 tests/sticky-chrome.e2e.ts · 1 passed 169ms
🟢 accepts the terms once the button clears the sticky footer 169ms
🟢 tests/virtualized-table.e2e.ts · 1 passed 14.7s
🟢 scrolls the windowed table to the Golden Row and claims it 14.7s
🟢 tests/wishlist.e2e.ts · 2 passed 1.5s
🟢 wishlist › saving toggles the button and the tab badge 229ms
🟢 wishlist › the wishlist tab renders the empty state despite the badge count (planted bug) 1.3s

Tested by e2e 0.23.1 · 1m 0s · web · run artifacts

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e web agent: 34 passed

35 agent steps · 26 replayed from cache · 25 model calls · 117.2k tokens (95% cached) · $0.0044

All 34 tests in 5 files
Test Agent Time
🟢 tests-agent/control-inventory.e2e.ts · 7 passed 7 steps 7.2s
🟢 control inventory › check sets the checkbox and the radio 1 step 661ms
🟢 control inventory › check picks a radio the pick replaces with its summary 1 step 245ms
🟢 control inventory › a long press and a double click are chosen over a plain tap 1 step 882ms
🟢 control inventory › a right-click opens the file menu and Rename renames the file 1 step 2.5s
🟢 control inventory › upload attaches the named project files 1 step 2.4s
🟢 control inventory › back returns from the details view to the inventory 1 step 242ms
🟢 control inventory › scroll_to brings the footnote into view 1 step 349ms
🟢 tests-agent/login-form.e2e.ts · 1 passed 1 step 351ms
🟢 act signs in with the benchmark account 1 step 351ms
🟢 tests-agent/planted-bugs.e2e.ts · 3 passed 4 steps · 8 calls 12.4s
🟢 cart totals: a judgment catches the stale order summary 2 steps · 4 calls 5.8s
🟢 checkout review: a judgment catches the broken copy 1 step · 1 call 1.3s
🟢 wishlist: a judgment catches the lost saved items 1 step · 3 calls 5.2s
🟢 tests-agent/scenarios.e2e.ts · 22 passed 22 steps · 17 calls 1m 13s
🟢 act completes shadow-dom-form 1 step · 3 calls 3.6s
🟢 act completes lying-labels 1 step · 3 calls 4.7s
🟢 act completes iframe-form 1 step · 3 calls 3.9s
🟢 act completes infinite-scroll 1 step 3.2s
🟢 act completes virtualized-table 1 step 15.4s
🟢 act completes overlay-trap 1 step 844ms
🟢 act completes sticky-chrome 1 step 907ms
🟢 act completes async-states 1 step · 3 calls 7.1s
🟢 act completes debounced-search 1 step 2.3s
🟢 act completes hover-menu 1 step 478ms
🟢 act completes drag-and-drop 1 step 416ms
🟢 act completes kanban-board 1 step 610ms
🟢 act completes context-menu-trap 1 step 2.6s
🟢 act completes stale-dom 1 step 431ms
🟢 act completes otp-auto-advance 1 step 685ms
🟢 act completes date-picker 1 step 804ms
🟢 act completes rich-text-editor 1 step 10.0s
🟢 act completes playbook-cleanup 1 step 510ms
🟢 act completes promo-storefront 1 step 2.3s
🟢 act completes new-tab-flow 1 step · 5 calls 9.3s
🟢 act completes gift-card-purchase 1 step 2.4s
🟢 act filters the list and the URL carries the filter 1 step 194ms
🟢 tests-agent/unique-cache.e2e.ts · 1 passed 1 step 254ms
🟢 act adds an address with a run-unique label 1 step 254ms

Tested by e2e 0.23.1 · 1m 33s · web · run artifacts

@kdy1
kdy1 force-pushed the kdy1/e2e-core-2-move branch from 7024414 to e7136e8 Compare November 13, 2026 07:02
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e ios agent: 21 passed, 1 skipped

25 agent steps · 12 replayed from cache · 60 model calls · 385.6k tokens (80% cached) · $0.0277

All 22 tests in 1 file
Test Agent Time
⏭️ tests-agent/scenarios.e2e.ts · 21 passed, 1 skipped 25 steps · 60 calls 8m 55s
🟢 act completes Login Form 1 step 42.8s
🟢 act completes Infinite Scroll List 1 step 37.8s
🟢 act completes Modal Flow 1 step 10.1s
🟢 act completes Bottom Tabs 1 step 7.5s
🟢 act completes Text Input Variations 1 step 12.5s
🟢 act completes Broken Accessibility 2 steps · 6 calls 26.9s
🟢 act completes Vision Only 2 steps · 6 calls 29.7s
🟢 act completes Gestures 1 step · 9 calls 37.7s
🟢 act completes Async States 1 step · 10 calls 37.5s
🟢 act completes Debounced Search 1 step · 1 call 27.1s
🟢 act completes Flattened Registration Form 2 steps · 1 call 25.9s
🟢 act completes Flattened Login 2 steps · 10 calls 52.4s
🟢 act completes Sticky Chrome Target 1 step 12.9s
🟢 act completes WebView Accessibility 1 step 12.9s
🟢 act completes Permission Prompt 1 step 11.2s
🟢 act completes Photo Picker 1 step · 2 calls 32.0s
🟢 act completes Product Catalog 1 step 10.3s
🟢 act completes Error Recovery 1 step 10.0s
🟢 act completes Choice Controls 1 step · 5 calls 34.4s
🟢 act completes Stripe PaymentSheet 1 step · 10 calls 52.7s
🟢 act completes Apple Pay 1 step 10.4s
⏭️ act completes Apple Pay Billing Address (skipped: the CI simulator's Apple Pay sheet skips the billing-address step, so the scenario cannot be completed there)

Tested by e2e 0.23.1 · 8m 55s · ios-simulator · run artifacts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CONTRIBUTING.md">

<violation number="1" location="CONTRIBUTING.md:292">
P2: The new public-surface list still omits `e2e/agent`, although the package exports it as `dist/agent/public.d.ts`. Add `e2e/agent` and its declaration path so agent API changes are not incorrectly treated as outside the breaking-change policy.</violation>
</file>

<file name=".changeset/config.json">

<violation number="1" location=".changeset/config.json:16">
P1: Adding `e2e-core` to this fixed group makes the release workflow publish it, but the new package must exist on npm and have the `release.yml` trusted publisher configured first. Complete that bootstrap before merging; otherwise the first release can fail or publish `e2e` with its exact `e2e-core` dependency unavailable.</violation>
</file>

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread .changeset/config.json Outdated
"fixed": [
[
"e2e",
"e2e-core"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Adding e2e-core to this fixed group makes the release workflow publish it, but the new package must exist on npm and have the release.yml trusted publisher configured first. Complete that bootstrap before merging; otherwise the first release can fail or publish e2e with its exact e2e-core dependency unavailable.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .changeset/config.json, line 16:

<comment>Adding `e2e-core` to this fixed group makes the release workflow publish it, but the new package must exist on npm and have the `release.yml` trusted publisher configured first. Complete that bootstrap before merging; otherwise the first release can fail or publish `e2e` with its exact `e2e-core` dependency unavailable.</comment>

<file context>
@@ -1,11 +1,21 @@
+  "fixed": [
+    [
+      "e2e",
+      "e2e-core"
+    ]
+  ],
</file context>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude-opus-5-5] responding on behalf of kdy1

Agreed, and it is the maintainer's to do: the first publish of e2e-core and its trusted publisher need npm org access. The PR body lists it under "Before merging". Leaving this open for the maintainer.

Comment thread CONTRIBUTING.md Outdated
Comment on lines +292 to +294
- Public types exported from `e2e`, `e2e/engine`, and `e2e-core/engine`,
as emitted in `dist/index.d.ts` and `dist/engine/index.d.ts` of `e2e`,
and `dist/engine/index.d.ts` of `e2e-core`. Removing an

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The new public-surface list still omits e2e/agent, although the package exports it as dist/agent/public.d.ts. Add e2e/agent and its declaration path so agent API changes are not incorrectly treated as outside the breaking-change policy.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At CONTRIBUTING.md, line 292:

<comment>The new public-surface list still omits `e2e/agent`, although the package exports it as `dist/agent/public.d.ts`. Add `e2e/agent` and its declaration path so agent API changes are not incorrectly treated as outside the breaking-change policy.</comment>

<file context>
@@ -289,8 +289,9 @@ committed.
 
-- Public types exported from `e2e` and `e2e/engine`, as
-  emitted in `dist/index.d.ts` and `dist/engine/index.d.ts`. Removing an
+- Public types exported from `e2e`, `e2e/engine`, and `e2e-core/engine`,
+  as emitted in `dist/index.d.ts` and `dist/engine/index.d.ts` of `e2e`,
+  and `dist/engine/index.d.ts` of `e2e-core`. Removing an
</file context>
Suggested change
- Public types exported from `e2e`, `e2e/engine`, and `e2e-core/engine`,
as emitted in `dist/index.d.ts` and `dist/engine/index.d.ts` of `e2e`,
and `dist/engine/index.d.ts` of `e2e-core`. Removing an
- Public types exported from `e2e`, `e2e/agent`, `e2e/engine`, and
`e2e-core/engine`, as emitted in `dist/index.d.ts`,
`dist/agent/public.d.ts`, and `dist/engine/index.d.ts` of `e2e`, and
`dist/engine/index.d.ts` of `e2e-core`. Removing an

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude-opus-5-5] responding on behalf of kdy1

e2e/agent is missing from this list on main too; this PR only adds e2e-core/engine to it. Whether the stability policy covers e2e/agent is a contract decision, so I am leaving it for the maintainer.

Comment thread packages/e2e/src/oauth/chatgpt.ts Resolved
Comment thread packages/mobile/package.json Resolved
Comment thread scripts/install-smoke.ts Resolved
Comment thread packages/web/src/engine.ts Resolved
Comment thread packages/mobile/README.md Resolved
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e android agent: 1 flaky, 19 passed

24 agent steps · 15 replayed from cache · 51 model calls · 383.9k tokens (86% cached) · $0.0231

⚠️ 1 flaky test passed on a retry

⚠️ act completes Gestures
tests-agent/scenarios.e2e.ts:266

ASSERTION_FAILED at step 4 of 4: agent.act "Complete this scenario as the screen instructs: long-press the first target, swipe the card left, then double-tap the last target", after 19.8s and 8 model calls

agent.act failed: The initial long-press was already completed. I attempted the required left swipe repeatedly on the “Swipe me left” card, but the screen remained on Step 2 of 3 and did not register the swipe, so the final double-tap target was not reached.

  • Turn 5: screenshot({}) → [screenshot] The screen changed substantially since revision b8. Current screen (revision b10, path dev.e2e.benchmark, 18 nodes):
  • Turn 6: swipe({"from":{"x":245,"y":450},"to":{"x":5,"y":450}}) → [swipe] Swiped from (245, 450) to (5, 450).
  • Turn 7: screenshot({}) → [screenshot] The screen changed substantially since revision b10. Current screen (revision b12, path dev.e2e.benchmark, 18 nodes):
  • Screen: dev.e2e.benchmark

Evidence: screenshot, log

All 20 tests in 1 file
Test Agent Time
⚠️ tests-agent/scenarios.e2e.ts · 1 flaky, 19 passed 24 steps · 51 calls 5m 56s
🟢 act completes Login Form 1 step 21.2s
🟢 act completes Infinite Scroll List 1 step 16.5s
🟢 act completes Modal Flow 1 step 9.9s
🟢 act completes Bottom Tabs 1 step 6.5s
🟢 act completes Text Input Variations 1 step 5.9s
🟢 act completes Broken Accessibility 2 steps · 5 calls 14.6s
🟢 act completes Vision Only 2 steps · 1 call 5.8s
⚠️ act completes Gestures (1 failed attempt first) 1 step · 13 calls 32.2s
🟢 act completes Async States 1 step · 20 calls 44.1s
🟢 act completes Debounced Search 1 step 6.6s
🟢 act completes Huge Virtualized List 1 step 1m 48s
🟢 act completes Flattened Registration Form 2 steps · 1 call 7.1s
🟢 act completes Flattened Login 2 steps · 6 calls 14.0s
🟢 act completes Sticky Chrome Target 1 step 8.7s
🟢 act completes WebView Accessibility 1 step · 5 calls 14.4s
🟢 act completes Permission Prompt 1 step 6.1s
🟢 act completes Product Catalog 1 step 8.1s
🟢 act completes Error Recovery 1 step 8.7s
🟢 act completes Choice Controls 1 step 8.1s
🟢 act completes Sequential Onboarding 1 step 9.2s

Tested by e2e 0.23.1 · 6m 19s · android-emulator · run artifacts

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e android: 58 passed, 1 skipped

All 59 tests in 7 files
Test Time
⏭️ tests/controls.e2e.ts · 24 passed, 1 skipped 2m 35s
🟢 control inventory › a label query resolves a labeled text field 20.4s
🟢 control inventory › a labeled field answers name, display value, value reads, fill, and clear 11.4s
🟢 control inventory › a placeholder query and attribute reads find the field 5.0s
🟢 control inventory › a secure field takes a fill and denies value reads 6.0s
🟢 control inventory › press sends a character and Enter through the soft keyboard 7.1s
🟢 control inventory › a field autofocuses on mount and focus() moves the focus 7.1s
🟢 control inventory › toBeFocused follows the focus 7.7s
🟢 control inventory › a switch checks, unchecks, and reports its state 8.3s
🟢 control inventory › checkbox and radio roles answer getByRole, and a checkbox toggles by tap 6.4s
🟢 control inventory › checkbox and radio roles check, uncheck, and report their state 10.1s
🟢 control inventory › a tab role answers getByRole 3.6s
🟢 control inventory › a radio group reports the checked option 7.3s
🟢 control inventory › buttons report disabled, enabled, and a state that arrives later 6.7s
🟢 control inventory › a display: none element is absent rather than hidden, its visible twin attached 6.2s
🟢 control inventory › a header answers its accessible name 3.6s
🟢 control inventory › a tab row answers count, all, texts, filters, positions, and switching 5.1s
🟢 control inventory › a list answers counts, list-form text, reads, and boxes in order 5.3s
⏭️ control inventory › a row contains its texts (skipped: React Native flattens a plain View out of the accessibility tree on both platforms: XCTest and the Android helper report a View with a testID as a leaf beside its children, so filter({ has }) and a query scoped to it match nothing; only Sc…)
🟢 control inventory › a long press lands as one 6.9s
🟢 control inventory › a double tap lands inside the 300 ms window 6.4s
🟢 control inventory › an ambiguous locator fails at once 4.8s
🟢 control inventory › screenshot, restart, and clearState reopen the app on its home list 6.4s
🟢 refusals › verbs a device never declares are refused before the engine 2ms
🟢 refusals › keys the soft keyboard cannot send are refused by the engine 1.7s
🟢 refusals › a missing locator fails as not found once its timeout passes 1.1s
🟢 tests/device-fixture.e2e.ts · 11 passed 1m 18s
🟢 device fixture › setOrientation rotates the window the app measures 4.9s
🟢 device fixture › home leaves the app, openApp brings it back where it was 4.1s
🟢 device fixture › foregroundApp sees the home screen after home() 3.7s
🟢 device fixture › closeApp then openApp relaunches on the home list 6.2s
🟢 device fixture › closeApp leaves the next commands on the same device 6.6s
🟢 device fixture › foregroundApp after closeApp reports the closed session as APP_NOT_OPEN 4.3s
🟢 device fixture › openLink opens the scenario a deep link names 4.6s
🟢 device fixture › device.back pops the scenario 3.7s
🟢 device fixture › unstable_raw reaches the test session through the raw driver 3.2s
🟢 device fixture › setNetwork and setAirplaneMode change what the app sees 15.7s
🟢 device fixture › setLocation and clearLocation change what the app reads 20.5s
🟢 tests/device.e2e.ts · 5 passed 37.1s
🟢 permission prompt › allowing the system dialog enables the microphone 5.2s
🟢 permission prompt › a denied prompt recovers once the permission is granted outside 11.3s
🟢 sequential onboarding echoes the exact values 9.3s
🟢 onboarding rejects a malformed email before advancing 5.3s
🟢 dismissing the keyboard over choice controls leaves them as they were 6.0s
🟢 tests/flows-lists.e2e.ts · 7 passed 3m 3s
🟢 infinite scroll reaches the target item 27.3s
🟢 product catalog adds exactly two of the right variant 8.1s
🟢 gestures: long-press, then swipe left 7.4s
🟢 gestures: double-tap completes the flow 9.0s
🟢 sticky chrome: accept below the fold, then continue 10.2s
🟢 async states: load, pull to refresh, claim through the toast 11.4s
🟢 huge virtualized list reaches row 512 1m 49s
🟢 tests/flows.e2e.ts · 7 passed 48.2s
🟢 text inputs unlock the submit button 5.9s
🟢 filled text inputs report their values 5.2s
🟢 modal flow confirms through the native alert 8.4s
🟢 bottom tabs act inside the last tab 6.3s
🟢 error recovery retries, then confirms the delete 8.2s
🟢 choice controls place the exact order 5.8s
🟢 debounced search selects the target once results arrive 8.3s
🟢 tests/login-form.e2e.ts · 3 passed 25.7s
🟢 login form › rejects a malformed email 6.8s
🟢 login form › rejects an unknown account 6.9s
🟢 login form › signs in and logs out 12.0s
🟢 tests/smoke.e2e.ts · 1 passed 5.0s
🟢 home lists the scenarios and opens one 5.0s

Tested by e2e 0.23.1 · 8m 51s · android-emulator · run artifacts

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e ios: 56 passed, 1 skipped

All 57 tests in 7 files
Test Time
⏭️ tests/controls.e2e.ts · 23 passed, 1 skipped 3m 10s
🟢 control inventory › a label query resolves a labeled text field 13.8s
🟢 control inventory › a labeled field answers name, display value, value reads, fill, and clear 15.8s
🟢 control inventory › a placeholder query and attribute reads find the field 5.9s
🟢 control inventory › a secure field takes a fill and denies value reads 9.2s
🟢 control inventory › press sends a character and Enter through the soft keyboard 14.2s
🟢 control inventory › a field autofocuses on mount and focus() moves the focus 12.2s
🟢 control inventory › toBeFocused follows the focus 9.9s
🟢 control inventory › a switch checks, unchecks, and reports its state 10.1s
🟢 control inventory › checkbox and radio roles answer getByRole, and a checkbox toggles by tap 8.6s
🟢 control inventory › checkbox and radio roles check, uncheck, and report their state 12.9s
🟢 control inventory › a radio group reports the checked option 9.4s
🟢 control inventory › buttons report disabled, enabled, and a state that arrives later 7.7s
🟢 control inventory › a display: none element is absent rather than hidden, its visible twin attached 7.2s
🟢 control inventory › a header answers its accessible name 4.3s
🟢 control inventory › a tab row answers count, all, texts, filters, positions, and switching 6.2s
🟢 control inventory › a list answers counts, list-form text, reads, and boxes in order 6.8s
⏭️ control inventory › a row contains its texts (skipped: React Native flattens a plain View out of the accessibility tree on both platforms: XCTest and the Android helper report a View with a testID as a leaf beside its children, so filter({ has }) and a query scoped to it match nothing; only Sc…)
🟢 control inventory › a long press lands as one 8.7s
🟢 control inventory › pointer verbs land at the point asked for 9.0s
🟢 control inventory › an ambiguous locator fails at once 5.4s
🟢 control inventory › screenshot, restart, and clearState reopen the app on its home list 10.8s
🟢 refusals › verbs a device never declares are refused before the engine 2ms
🟢 refusals › keys the soft keyboard cannot send are refused by the engine 409ms
🟢 refusals › a missing locator fails as not found once its timeout passes 1.2s
🟢 tests/device-fixture.e2e.ts · 12 passed 1m 58s
🟢 device fixture › setAppearance flips the color scheme the app reads 13.3s
🟢 device fixture › setOrientation rotates the window the app measures 6.5s
🟢 device fixture › the clipboard reads back what was written 9.7s
🟢 device fixture › home leaves the app, openApp brings it back where it was 9.0s
🟢 device fixture › closeApp then openApp relaunches on the home list 9.0s
🟢 device fixture › closeApp leaves the next commands on the same device 13.9s
🟢 device fixture › foregroundApp after closeApp reports the closed session as APP_NOT_OPEN 7.1s
🟢 device fixture › openLink opens the scenario a deep link names 16.4s
🟢 device fixture › device.back pops the scenario 6.9s
🟢 device fixture › unstable_raw reaches the test session through the raw driver 4.8s
🟢 device fixture › setLocation and clearLocation change what the app reads 10.3s
🟢 device fixture › enrollBiometrics and setBiometrics answer a biometric prompt 10.7s
🟢 tests/device.e2e.ts · 3 passed 47.8s
🟢 sequential onboarding echoes the exact values 26.6s
🟢 onboarding rejects a malformed email before advancing 9.8s
🟢 dismissing the keyboard over choice controls leaves them as they were 11.3s
🟢 tests/flows-lists.e2e.ts · 7 passed 4m 0s
🟢 infinite scroll reaches the target item 36.2s
🟢 product catalog adds exactly two of the right variant 10.5s
🟢 gestures: long-press, then swipe left 8.7s
🟢 sticky chrome: accept below the fold, then continue 12.4s
🟢 async states: load, pull to refresh, claim through the toast 11.4s
🟢 huge virtualized list reaches row 512 2m 29s
🟢 web view coupon form applies the code shown on the page 11.8s
🟢 tests/flows.e2e.ts · 7 passed 1m 9s
🟢 text inputs unlock the submit button 12.1s
🟢 filled text inputs report their values 10.8s
🟢 modal flow confirms through the native alert 10.0s
🟢 bottom tabs act inside the last tab 7.5s
🟢 error recovery retries, then confirms the delete 9.3s
🟢 choice controls place the exact order 7.5s
🟢 debounced search selects the target once results arrive 11.5s
🟢 tests/login-form.e2e.ts · 3 passed 44.5s
🟢 login form › rejects a malformed email 12.7s
🟢 login form › rejects an unknown account 12.8s
🟢 login form › signs in and logs out 19.1s
🟢 tests/smoke.e2e.ts · 1 passed 7.9s
🟢 home lists the scenarios and opens one 7.9s

Tested by e2e 0.23.1 · 6m 45s · ios-simulator · run artifacts

@kdy1

kdy1 commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

[claude-opus-5-5] responding on behalf of kdy1

Left for the maintainer:

@kdy1
kdy1 added this pull request to stack #1738 November 13, 2026 07:32
@kdy1
kdy1 force-pushed the kdy1/e2e-core-2-move branch from 2ae0215 to e61e085 Compare November 14, 2026 05:18
@okwasniewski okwasniewski changed the title refactor: move e2e's core into e2e-core, and engines peer on it refactor: move e2e's core into @e2e-dev/core, and engines peer on it Nov 15, 2026
Base automatically changed from kdy1/e2e-core-1-split to main November 15, 2026 18:05
kdy1 and others added 3 commits November 15, 2026 18:06
The engine contract, locators, agent, replay cache, secrets, and the
session half of a worker move from packages/e2e to packages/core, the new
@e2e-dev/core package, at the same paths. e2e depends on it at its exact
version (a changesets fixed group) and reaches its modules through
@e2e-dev/core/lib/*, which is not public API; e2e/engine and e2e/agent
re-export it. @e2e-dev/web and @e2e-dev/mobile peer on @e2e-dev/core and
import the contract from @e2e-dev/core/engine. Install smoke checks that one
copy of @e2e-dev/core is installed.

Most of this diff is git mv and import specifiers rewritten to
@e2e-dev/core/lib/<path>; no behavior changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Bun job built e2e before the @e2e-dev/core it compiles against, and the
examples nightly installs e2e from a tarball whose exact @e2e-dev/core is
not on npm; it now packs @e2e-dev/core and overrides it in each example.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Engines peer on @e2e-dev/core. Yarn installs no peer the project does
not list, and under Plug'n'Play the engine then fails to load.

- init adds @e2e-dev/core with any engine
- upgrade adds a required @e2e-dev peer the project lacks, and keeps a
  package e2e depends on at the version e2e names
@okwasniewski
okwasniewski added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 0a5ee16 Nov 15, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines, not counting tests, fixtures, or the lockfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants