Skip to content

fix(examples): install from the 0.23.0 runner and engine releases - #1729

Merged
okwasniewski merged 2 commits into
e2e-inc:mainfrom
ijaidev:fix/examples-versions
Nov 12, 2026
Merged

okwasniewski merged 2 commits into
e2e-inc:mainfrom
ijaidev:fix/examples-versions

Conversation

@ijaidev

@ijaidev ijaidev commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Issue

Refs #1657

Verified

Ran it locally: yes

  • npm install --dry-run in all 9 changed examples: every tree resolves.
  • Web examples, normal npm install plus the suite:
Example Install Suite
with-vite pass 5 passed: 3 deterministic, 2 agent on a temporary opencodeConsole('go/deepseek-v4.1-flash') model
with-next pass 3 passed, 2 agent skipped
with-astro pass 3 passed, 2 agent skipped
with-angular pass 3 passed, 2 agent skipped
with-expo (web) pass 3 passed, 2 agent skipped; already on the new set on main
  • Native examples (with-compose, with-flutter, with-kotlin-multiplatform, with-maui): npm install --ignore-scripts passes. Their suites need an iOS simulator or Android emulator, so they were skipped for now.

examples/with-vite on main fails at npm install; on this branch it installs and all 5 tests pass.

Checklist

  • No changeset: examples are private, outside the pnpm workspace, and publish nothing.
  • No breaking change and no public contract change; only devDependency ranges.
  • Docs: the four web example READMEs this PR changes record the 0.23.0 check. with-expo is already current on main. Native READMEs are unchanged because their suites were not run.

View guided diff

@github-actions github-actions Bot added the size:M Up to 99 changed lines, not counting tests, fixtures, or the lockfile label Nov 12, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

View guided diff | Re-trigger cubic

Comment thread examples/with-expo/package.json Resolved
Comment thread examples/with-vite/package.json Resolved
Comment thread examples/with-next/package.json Resolved
Comment thread examples/with-astro/package.json Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

View guided diff | Re-trigger cubic

@ijaidev
ijaidev force-pushed the fix/examples-versions branch from 355ae1e to 101e191 Compare November 12, 2026 19:33
@ijaidev

ijaidev commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

All four workflows (spec, benchmark, docs, mobile) are waiting for approval on 101e191 because this PR comes from a fork. The PR policy check passed, cubic's re-review is clean, and there are no unresolved threads. Could a maintainer approve the workflow runs on this head?

@okwasniewski okwasniewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude-opus-5-5] automated review on behalf of @okwasniewski

Verified locally: on main with-vite and with-compose/e2e hit ERESOLVE on e2e@0.22.0, this branch resolves. with-vite on the branch installs e2e 0.23.0 + web 0.15.5 deduped, tsc clean, 3 deterministic tests pass. Pins match #1705 and all 10 examples now agree. Native READMEs still say "last checked with 0.22.0 / 0.12.5" since those suites weren't rerun - fine. Root cause stays with #1661. Merging.

@okwasniewski
okwasniewski added this pull request to the merge queue Nov 12, 2026
Merged via the queue into e2e-inc:main with commit 79f70ae Nov 12, 2026
27 checks passed
@ijaidev
ijaidev deleted the fix/examples-versions branch November 13, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Human Review size:M Up to 99 changed lines, not counting tests, fixtures, or the lockfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants