Repository navigation
docs(mobile): say which device runs when no device is named - #1728
Conversation
A paired iPhone or iPad counts as booted and joins the pool; with none booted, agent-device boots an iPhone simulator over an iPad, then the newest OS, then name order.
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
okwasniewski
left a comment
There was a problem hiding this comment.
[claude-opus-5-5] automated review on behalf of @okwasniewski
Checked agent-device 0.21.36: cold pick is iPhone sim > iPad sim > Apple TV, then newest OS, then name. Matches.
One fix: the devicectl parser reports every listed (paired) Apple device as booted: true with no connection check, and pool.ts:166-171 keeps those. So a paired but offline phone also joins the pool. Please say "paired" instead of "connected" in mobile.mdx:468, the options.ts JSDoc/reference and the README row.
Optional: the pool.ts:151 log line still says "(newest OS, then name)".
Red check is an MCP Registry TLS timeout, not this PR. Rerunning.
…rs in the cold-pick order
|
Pushed 3df630f for the review: "paired" replaces "connected" for iPhone and iPad in mobile.mdx, the reference, the options.ts JSDoc, the README and the setup guide; the Apple TV and TV tiers are in every cold-pick description; the pool.ts log line now names the same order. Typechecked @e2e-dev/mobile with tsc; pnpm itself does not start here (corepack cache), so lint and docs checks run in CI. |
There was a problem hiding this comment.
0 issues found across 7 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
@okwasniewski the requested changes are in, ready for another look when you have time. |
okwasniewski
left a comment
There was a problem hiding this comment.
[claude-opus-5-5] automated review on behalf of @okwasniewski
Re-reviewed at 80f435d. "Paired" is now used everywhere we asked. The new Apple TV and Android TV tiers match agent-device 0.21.36: its inventory marks tvOS devices target: 'tv'. The cubic threads are handled and CI is green. One item is left:
.changeset/which-device-boots.md:5still says "connected" and does not mention the TV tier. Suggested text:The
deviceoption's documentation now says a paired iPhone or iPad counts as booted, and that a shut-down device boots in tiers: on iOS an iPhone, then an iPad, then an Apple TV; on Android a phone or tablet, then a TV.
Nits:
docs/mobile.mdx:469-471: the line breaks are uneven. Please reflow:a shut-down one: on iOS an iPhone before an iPad before an Apple TV, on Android a phone or tablet before a TV, then the newest OS, then name order. Two workers never drive the same device.docs/mobile.mdx:532: "paired phone" doesn't fit Android, where the phone is connected over adb. Maybe: "a paired iPhone or connected Android phone counts as booted".
After the changeset fix this is ready.
|
Heads-up: #1735 (agent-device 0.21.37) changes what this PR documents. On 0.21.37 a paired iPhone or iPad whose CoreDevice tunnel is Suggest wording like "a paired iPhone or iPad that is reachable (USB or network) counts as booted", and rebase after #1735 lands so the docs match the pinned version. |
|
Addressed in 7b34c8f: the changeset now names the TV tiers and "paired"; the |
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
@okwasniewski the requested changes are in, ready for another look when you have time. |
Asks done in 7b34c8f/6d2ec0b58.
okwasniewski
left a comment
There was a problem hiding this comment.
[claude-opus-5-5] automated review on behalf of @okwasniewski
Re-reviewed at 6d2ec0b. The changeset names "paired" and the TV tiers. The docs/mobile.mdx paragraph is reflowed, and the Android wording says "connected". "Reachable (USB or network)" matches agent-device 0.21.37 from #1735, which lists an unavailable paired iPhone as booted: false. CI green. Merging, thanks!
What and why
deviceand nothing booted, agent-device's pick ranks an iPhone simulator above an iPad, then the newest OS, then name order. The docs said only "newest OS, then name".device, a run on a Mac with a paired phone drives the phone.deviceJSDoc, its reference copy, the mobile guide, the package README and the setup skill.Issue
None (docs change).
Verified
Ran it locally: yes
agent-device boot --platform ios --pick newest(the requestbootRequestsends): booted iPhone 16e (iOS 26.3) over the shut-down iPad (A16) on iOS 26.3, whose name sorts first.mobile({ platform: 'ios' }), no simulator booted, three paired devices: the run drove the paired iPhone (Ran on: device 00008140-…).pnpm checkand@e2e-dev/mobiletests green.Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.!, the changeset body names what breaks and what replaces it, and the deprecation warning landed a window earlier (stability policy in CONTRIBUTING.md).docs/**/*.mdxpage for the behavior, andskills/e2e/if the skill describes it..d.tsreviewed,tests/types/sdk-types.tsupdated; wire change edits the schema and both fixtures.e2e/engine): changesets fore2e,@e2e-dev/web, and@e2e-dev/mobile.