Repository navigation
fix(web): check a radio or checkbox through its own label when the label covers it #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95cb7e7
fix(web): check a radio or checkbox through its own label when the la…
samanyudas c88fd0b
fix(web): skip the label stand-in for disabled fieldsets, hidden labe…
samanyudas dc700e8
fix(web): choose the label stand-in past loading masks and wait for a…
samanyudas 0c51c84
fix(web): click no control after a cancelled stand-in read, and dispo…
samanyudas 779130e
refactor(web): type the label stand-in as undefined instead of a null…
samanyudas 2e0883d
test(web): give the label refusal cases a 500ms deadline
samanyudas fc587db
Merge remote-tracking branch 'origin/main' into HEAD
okwasniewski 15e04fa
Merge branch 'main' into fix/web-check-through-label
samanyudas 8dc0761
Merge remote-tracking branch 'origin/main' into fix/web-check-through…
samanyudas dd7d358
test(web): resolve the element target through ElementList, as an obse…
samanyudas e05a6f1
docs(web): limit the label-click claims to what the click checks
samanyudas 3b87ad2
Merge branch 'main' into fix/web-check-through-label
samanyudas ec2c689
test(web): pin the clicked control and cover uncheck through a label
samanyudas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@e2e-dev/web": patch | ||
| --- | ||
|
|
||
| `check`, `uncheck`, and `tap` click a checkbox or radio hidden under its own label (as in Element Plus) through that label. `uncheck` still refuses a native radio without clicking it. Anything else on top of the point the click lands on still fails `ACTION_FAILED`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.