Repository navigation
fix(mobile): reject stale refs after transition refresh - #1300
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
There was a problem hiding this comment.
No issues found across 4 files
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
Thanks @shamilovtim, this is a clean fix. Dropping the fallback in What I checked on c076670:
Must fixNone. Nits
This was an automated review. |
|
[Codex] responding on behalf of shamilovtim Addressed in 1454929: the two JSDocs now state that the locator re-resolves after retryable NODE_STALE, the repeated inline comment is removed, and the reference uses the suggested user-facing sentence. This follow-up changes no runtime behavior. The PR body now records the relationship to #1297: that PR determines when a keyboard change requires a refresh; this one handles losing the target during the refresh. The keyboard-state prerequisite raised on #1297 is being checked separately. GitHub spec/docs/benchmark/mobile workflows still require maintainer approval at this head. The Ready for Human Review label is withheld until required checks actually run. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
|
Thanks @shamilovtim. Re-checked 1454929. All three nits are done:
No runtime change since c076670. On the head merged into current main (clean merge), Optional nit: rewrap I approved the fork CI runs. Ready for a maintainer once they pass. This was an automated review. |
# Conflicts: # packages/mobile/src/surface.ts
What and why
relocated()throws retryableNODE_STALEbefore any input (packages/mobile/src/surface.ts,relocated()), and the locator resolves the selector again within its timeout (performUntilre-resolves on retryableNODE_STALE).relocated()and should keep this throw when it merges after this PR.Issue
Closes #1299.
Verified
Ran it locally: no device run. Unit evidence on the head merged with main:
found === undefined ? entry : ...fallback fails both regressions: "acts on a control that came with the last action where a fresh snapshot lists it once the budget has passed" and "does not tap a recycled ref when a native button becomes a tab during relocation".pnpm checkand all 413 mobile unit tests pass.NODE_STALE, no input