Skip to content

chore: remove periodic tests - #3521

Merged
jakubno merged 2 commits into
mainfrom
chore/remove-periodic-tests
Aug 3, 2026
Merged

jakubno merged 2 commits into
mainfrom
chore/remove-periodic-tests

Conversation

@jakubno

@jakubno jakubno commented Aug 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@cla-bot cla-bot Bot added the cla-signed label Aug 3, 2026
@jakubno
jakubno marked this pull request as ready for review August 3, 2026 08:54
@jakubno
jakubno enabled auto-merge (squash) August 3, 2026 08:56
@cursor

cursor Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Removes production-adjacent monitoring and on-call signal for foxtrot, juliett, and staging; no runtime infra change, but regression detection may lag until checks are replaced.

Overview
This PR stops scheduled and path-triggered periodic smoke checks against live E2B domains (code execution, pause/resume, internet, template build and clock sync) and removes the incident.io alerting that ran on those workflow results. Operational coverage from this repo for those environments is reduced unless the same checks live elsewhere.

Reviewed by Cursor Bugbot for commit f9f13ca. Bugbot is set up for automated code reviews on this repo. Configure here.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward removal of the periodic-test CI workflow and its associated tests/periodic-test/ directory.

Extended reasoning...

Overview

This PR deletes the entire periodic-test infrastructure: the .github/workflows/periodic-test.yml cron/dispatch workflow, and all files under tests/periodic-test/ (test scripts, package.json, bun.lock, Dockerfile, utils). No production code (API, orchestrator, envd, client-proxy, shared, db, IaC) is touched — this is purely deletion of a self-contained CI test suite and its runner.

Security risks

None. The change only removes code; it does not add any new logic, credentials, or attack surface. If anything, it reduces surface area by removing a workflow that handled API keys/incident.io webhook tokens as GitHub secrets.

Level of scrutiny

Low. This is a mechanical, fully-additive-negative diff (file deletions only) with no changes to any runtime service or shared library. There's no ambiguity in intent (matches the commit title/history "chore: remove periodic tests"), and nothing here can introduce regressions in production behavior.

Other factors

The deleted workflow was independent (self-contained directory + its own CI file), so there's no dangling reference to clean up elsewhere. No CODEOWNERS-restricted paths are touched based on visible scope. Given the trivial, low-risk nature of a deletion-only PR, this does not warrant human review time.

@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@jakubno
jakubno merged commit 7dc42c0 into main Aug 3, 2026
51 checks passed
@jakubno
jakubno deleted the chore/remove-periodic-tests branch August 3, 2026 09:07
jakubno added a commit that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants