Skip to content

test(sdk): match run_cmd build error without the command name - #2014

Merged
mishushakov merged 1 commit into
mainfrom
devin/1792605332-run-cmd-error-msg
Oct 21, 2026
Merged

mishushakov merged 1 commit into
mainfrom
devin/1792605332-run-cmd-error-msg

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The orchestrator stopped repeating the failed command in template build errors (e2b-dev/runtime 4b3b122 "fix(orchestrator): report a failed build command without repeating it"), and that's now deployed to production as well as staging:

- failed to run command 'whoami': command failed: unauthenticated: invalid username: 'root123'
+ failed to run command: command failed: unauthenticated: invalid username: 'root123'

test_run_command_as_user_that_does_not_exist (Python sync + async) and runCmd.test.ts > run command as user that does not exist (JS) still asserted the old message, so they fail on every PR that runs the SDK suites (e.g. #2010, feat/en-3411-allow-default-dns). This PR updates the expected string only, with no SDK changes.

Ran the changed tests against production: Python 6 passed, JS 3 passed.

Link to Devin session: https://app.devin.ai/sessions/44907c1a82f44d669290264aad35ed9a
Open in Devin Desktop: https://app.devin.ai/desktop/session/44907c1a82f44d669290264aad35ed9a?variant=devin
Requested by: @mishushakov


Devin Review

Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@cla-bot cla-bot Bot added the cla-signed label Oct 21, 2026
@changeset-bot

changeset-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b05c0d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from 18f4d14. Download artifacts from this workflow run.

JS SDK (e2b@2.58.1-devin-1792605332-run-cmd-error-msg.0, with @e2b/dockerfile-utils@0.1.2-devin-1792605332-run-cmd-error-msg.0):

npm install ./e2b-dockerfile-utils-0.1.2-devin-1792605332-run-cmd-error-msg.0.tgz ./e2b-2.58.1-devin-1792605332-run-cmd-error-msg.0.tgz

CLI (@e2b/cli@2.22.4-devin-1792605332-run-cmd-error-msg.0):

npm install ./e2b-cli-2.22.4-devin-1792605332-run-cmd-error-msg.0.tgz

Code Interpreter JS SDK (@e2b/code-interpreter@2.9.1-devin-1792605332-run-cmd-error-msg.0):

npm install ./e2b-code-interpreter-2.9.1-devin-1792605332-run-cmd-error-msg.0.tgz

Desktop JS SDK (@e2b/desktop@2.5.1-devin-1792605332-run-cmd-error-msg.0):

npm install ./e2b-desktop-2.5.1-devin-1792605332-run-cmd-error-msg.0.tgz

Python SDK (e2b==2.58.0+devin.1792605332.run.cmd.error.msg, with e2b-dockerfile-utils==0.1.1+devin.1792605332.run.cmd.error.msg):

pip install ./e2b_dockerfile_utils-0.1.1+devin.1792605332.run.cmd.error.msg-py3-none-any.whl ./e2b-2.58.0+devin.1792605332.run.cmd.error.msg-py3-none-any.whl

Code Interpreter Python SDK (e2b-code-interpreter==2.11.2+devin.1792605332.run.cmd.error.msg):

pip install ./e2b_code_interpreter-2.11.2+devin.1792605332.run.cmd.error.msg-py3-none-any.whl

Desktop Python SDK (e2b-desktop==2.7.1+devin.1792605332.run.cmd.error.msg):

pip install ./e2b_desktop-2.7.1+devin.1792605332.run.cmd.error.msg-py3-none-any.whl

@mishushakov
mishushakov marked this pull request as ready for review October 21, 2026 17:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T18:00:36.688981Z b05c0d3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TASTE.md review: compliant, 0 violations. This PR changes only test assertions, updating the expected server build-error string the same way in the JS, sync Python and async Python tests (T-1/T-2 parity kept). It touches no public SDK surface, so the API-shape, error and docstring rules (T-3–T-74) do not apply.

@mishushakov
mishushakov merged commit 5ad398f into main Oct 21, 2026
71 of 85 checks passed
@mishushakov
mishushakov deleted the devin/1792605332-run-cmd-error-msg branch October 21, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant