Repository navigation
test(sdk): match run_cmd build error without the command name - #2014
Conversation
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Package ArtifactsBuilt from 18f4d14. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.2-devin-1792605332-run-cmd-error-msg.0.tgz ./e2b-2.58.1-devin-1792605332-run-cmd-error-msg.0.tgzCLI ( npm install ./e2b-cli-2.22.4-devin-1792605332-run-cmd-error-msg.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.1-devin-1792605332-run-cmd-error-msg.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1792605332-run-cmd-error-msg.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.1+devin.1792605332.run.cmd.error.msg-py3-none-any.whl ./e2b-2.58.0+devin.1792605332.run.cmd.error.msg-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.2+devin.1792605332.run.cmd.error.msg-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.1+devin.1792605332.run.cmd.error.msg-py3-none-any.whl |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
TASTE.md review: compliant, 0 violations. This PR changes only test assertions, updating the expected server build-error string the same way in the JS, sync Python and async Python tests (T-1/T-2 parity kept). It touches no public SDK surface, so the API-shape, error and docstring rules (T-3–T-74) do not apply.
Summary
The orchestrator stopped repeating the failed command in template build errors (e2b-dev/runtime
4b3b122"fix(orchestrator): report a failed build command without repeating it"), and that's now deployed to production as well as staging:test_run_command_as_user_that_does_not_exist(Python sync + async) andrunCmd.test.ts > run command as user that does not exist(JS) still asserted the old message, so they fail on every PR that runs the SDK suites (e.g. #2010,feat/en-3411-allow-default-dns). This PR updates the expected string only, with no SDK changes.Ran the changed tests against production: Python 6 passed, JS 3 passed.
Link to Devin session: https://app.devin.ai/sessions/44907c1a82f44d669290264aad35ed9a
Open in Devin Desktop: https://app.devin.ai/desktop/session/44907c1a82f44d669290264aad35ed9a?variant=devin
Requested by: @mishushakov