Repository navigation
fix(deps): CVE-2026-96889 (high) — bump sharp override to ^0.35.5 (GHSA-wq5f-xc86-pv6w) - #1995
Conversation
…2026-96889, high) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Package ArtifactsBuilt from 92bafbc. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.2-devin-1792393587-sharp-ghsa-wq5f.0.tgz ./e2b-2.56.1-devin-1792393587-sharp-ghsa-wq5f.0.tgzCLI ( npm install ./e2b-cli-2.22.1-devin-1792393587-sharp-ghsa-wq5f.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.1-devin-1792393587-sharp-ghsa-wq5f.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1792393587-sharp-ghsa-wq5f.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.1+devin.1792393587.sharp.ghsa.wq5f-py3-none-any.whl ./e2b-2.56.0+devin.1792393587.sharp.ghsa.wq5f-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.0+devin.1792393587.sharp.ghsa.wq5f-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.0+devin.1792393587.sharp.ghsa.wq5f-py3-none-any.whl |
There was a problem hiding this comment.
I reviewed this and found no bugs. It's a clean patch-level bump of the sharp override, but the repo's CODEOWNERS file assigns every path to one owner, so they should still sign off.
What was reviewed:
- The
sharp@<0.35.5: ^0.35.5override is the same in pnpm-workspace.yaml and in the pnpm-lock.yaml overrides block. - No references to sharp 0.35.4 or
@ img/sharp-libvips-*@ 1.3.3are left in the lockfile. The miniflare snapshots and the root sharp entries now resolve to 0.35.5 and libvips 1.3.4. - The
@ img/sharp-*platform entries that remain are a complete, consistent set at 0.35.5 / 1.3.4.
Extended reasoning...
The change touches only pnpm-workspace.yaml (one override line) and pnpm-lock.yaml. In the lockfile, sharp 0.35.4 and libvips 1.3.3 are removed and their dependents dedupe onto the 0.35.5 entries that were already there. No source code changes and no runtime security surface is touched. sharp is a dev-only transitive dependency, pulled in through wrangler and miniflare. I checked the resulting files rather than the raw diff hunks, and the lockfile state matches the override. I deferred instead of approving only because CODEOWNERS assigns every path in the repo, these files included, to a single owner.
|
can you resolve conflicts in the lock file |
…p-ghsa-wq5f Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # pnpm-lock.yaml
|
|
Resolved: merged |
|
CI on the merge commit: the remaining failures come from the live API, not this change. After the merge, the only difference from
I don't have permission to re-run jobs, so they need a re-run once staging is healthy. |
Summary
Clears GHSA-wq5f-xc86-pv6w (high):
sharp <0.35.5bundles a librsvg vulnerable to CVE-2026-96889. The GHSA itself has no CVE ID assigned; the CVE in the title is the upstream librsvg one it references.Patch-level bump of the existing override. When this PR was opened,
sharp@0.35.4came in through thepackages/js-sdkdevDependency chainwrangler > miniflare > sharp. #1994 has since bumpedwrangleronmain, so the resolved tree is already onsharp@0.35.5. After mergingmain, this PR only raises the override floor so a vulnerablesharpcan't be resolved again. 0.35.5 was published 2026-09-27, so it satisfiesminimumReleaseAge.Dev-only: no published package (
e2b,@e2b/cli, Python SDK) depends onsharp, so no changeset.Verification
pnpm install --frozen-lockfilepasses.pnpm why -r sharpshows onlysharp@0.35.5.pnpm audit: the sharp advisory no longer shows up. What's left isbraces(high, CVE-2026-93687) andsprintf-js(moderate, CVE-2026-97058). Neither has a patched version, and both come only through@changesets/*release tooling.Link to Devin session: https://app.devin.ai/sessions/4bc93953132c4fc3808932cf35fde056
Open in Devin Desktop: https://app.devin.ai/desktop/session/4bc93953132c4fc3808932cf35fde056?variant=devin