Non-counting questions - #2450
Open
jooooosef wants to merge 31 commits into
Open
Conversation
jooooosef
marked this pull request as draft
May 26, 2025 19:35
jooooosef
marked this pull request as ready for review
June 17, 2025 09:11
richardebeling
left a comment
richardebeling
left a comment
Member
There was a problem hiding this comment.
Looking pretty good, thanks :)
jooooosef
force-pushed
the
iss2391
branch
2 times, most recently
from
July 21, 2025 19:59
7386f67 to
6b24166
Compare
niklasmohrin
requested changes
Jul 28, 2025
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
okay some more concerns; this is not an easy issue :^)
richardebeling
removed their request for review
August 4, 2025 15:27
jooooosef
force-pushed
the
iss2391
branch
2 times, most recently
from
August 11, 2025 20:38
3eb3935 to
3f26948
Compare
janno42
force-pushed
the
main
branch
2 times, most recently
from
August 12, 2025 11:21
73e348c to
3577b6a
Compare
Kakadus
reviewed
Oct 27, 2025
richardebeling
requested changes
Nov 4, 2025
jooooosef
force-pushed
the
iss2391
branch
2 times, most recently
from
November 24, 2025 22:33
77f11b9 to
d360f52
Compare
matches the behaviour from the allows_additional_text_answer in QuestionForm
enforce counts_for_grade on model level
direclty fetch question in the first call, so we dont have to requery the db afterward every time
- when wrong values are submitted we now actively reject the request - also add tests
…de is set wrongly also, and unfortunatly, fix tests
- see test_can_change_question in staff/test_views.py
niklasmohrin
approved these changes
Aug 10, 2026
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
Only minor comments, overall approve 🎉
| counts_for_grade=True, | ||
| ) | ||
|
|
||
| page = self.app.get(f"/staff/questionnaire/{questionnaire.pk}/edit", user=self.manager) |
| ), | ||
| name="check_evaluation_textanswer_or_heading_question_has_no_additional_textanswers", | ||
| ) | ||
| ), |
fingers crossed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2391
fixes #2539
Note: Since I changed the
RatingResult(addedcounts_for_grade) you may have torefresh_results_cachefor sites like "Evaluate" to work.