-
Notifications
You must be signed in to change notification settings - Fork 4
Add devcontainer configuration excluding rJava #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 86.80% 88.79% +1.98%
==========================================
Files 20 27 +7
Lines 1993 2819 +826
==========================================
+ Hits 1730 2503 +773
- Misses 263 316 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a devcontainer configuration to facilitate development and testing of the rJavaEnv package in an environment without Java pre-installed. This is valuable for testing the package's core functionality of downloading and installing Java.
Changes:
- Added devcontainer configuration using Microsoft's R devcontainer base image
- Created setup scripts to install Posit Air CLI and R dependencies while explicitly excluding rJava
- Configured VS Code extensions for R, Quarto, and Posit Air development
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Defines the devcontainer configuration with base image, VS Code extensions, and post-create command |
.devcontainer/setup.sh |
Bash script that installs Posit Air CLI and executes R dependency setup |
.devcontainer/setup.R |
R script that reads DESCRIPTION and installs all dependencies except rJava |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension. - Update scripts to address PR review feedback (robust dependency handling, verification).
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension. - Update scripts to address PR review feedback (pinned version, security, robustness).
This PR adds a
.devcontainerconfiguration to the project. It sets up a development environment based onmcr.microsoft.com/devcontainers/r:latest.Key features:
.devcontainer/setup.R) readsDESCRIPTIONand installs all dependencies exceptrJava. This allows testing the package's functionality for downloading and installing Java.Posit.air-vscodeandquarto.quarto.postCreateCommandruns a setup script that installs the Air CLI and the R dependencies.PR created automatically by Jules for task 15392296075773728410 started by @e-kotov