Skip to content

ID match skeleton maps#100

Merged
e-koch merged 3 commits into
e-koch:masterfrom
pillswor:master
Nov 26, 2025
Merged

ID match skeleton maps#100
e-koch merged 3 commits into
e-koch:masterfrom
pillswor:master

Conversation

@pillswor

Copy link
Copy Markdown

Adjusted skeleton map in save_fits command to match to ID of filament+1 (i.e. filament 0 value in map is 1, etc...) for global filament-by-filament analysis post structure analysis.

Comment thread fil_finder/filfinder2D.py
Comment thread fil_finder/filfinder2D.py Outdated
@codecov

codecov Bot commented Nov 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.74%. Comparing base (aa03e4e) to head (f9be4e7).
⚠️ Report is 176 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (aa03e4e) and HEAD (f9be4e7). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (aa03e4e) HEAD (f9be4e7)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   72.46%   64.74%   -7.72%     
==========================================
  Files          18       19       +1     
  Lines        3290     3435     +145     
==========================================
- Hits         2384     2224     -160     
- Misses        906     1211     +305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@e-koch
e-koch merged commit e78392f into e-koch:master Nov 26, 2025
11 of 12 checks passed
@e-koch

e-koch commented Nov 26, 2025

Copy link
Copy Markdown
Owner

thanks @pillswor!

codecov failure seems to be because it hadn't been running for some time and is unrelated to changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants