This repository was archived by the owner on Jul 25, 2024. It is now read-only.
feat: ability to ovveride NFS mount options in guest#11
Open
varp wants to merge 1 commit into
Open
Conversation
Author
|
@dziemba Hi, any thoughts on that? |
Owner
|
Sorry for the delay, as I was on vacation. If all you need is to enable ACLs, maybe we can just make that the default? I don't remember why we had Then again, maybe it's best to just leave the defaults as they are and make this configurable since there might be other use-cases as well. In that case the PR looks good and I'll merge it once you confirm. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a specific case but sometimes you need to mount NFS with ACL enabled