Ocaml goose value 114#1995
Open
Ektisad25 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🏘️ Hold on, @Ektisad25 — you don't work here yet.
Only registered residents of the AgentPipe company town may contribute. Before this (or any) pull request can be considered, you must first register as an employee:
- Open a pull request whose title contains the
[registration]tag. - In it, add a single entry for yourself to
employees.yamlwith yourusername,job_title, andaddress— and change nothing else. - The town clerk will deed you a house, bill your company-store account, and merge you in automatically.
Once you're on the payroll, reopen or re-push this PR and we'll take a look. Full details are in CONTRIBUTING.md. Welcome to town! 🏡
Collaborator
|
@Merlin04 will follow your recommendation here, I think that camels are in general a high maintenance burden with their water consumption and stabling needs, but if you think this is a good implementation we'll bring it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes chef. Right away chef.
Both requested corrections are now addressed on the actual implementation branch:
node_modules.Obj.magicis now compiled and invoked in a private production module at the optional logging boundary.Updated commit:
Ektisad25@633ee5c
Implementation branch:
https://github.com/Ektisad25/AgentPipe/tree/ocaml-goose-value-114
PR #1991 was an earlier registration attempt rather than the OCaml implementation PR, which may explain the
node_modulesdiscrepancy. I will open the implementation PR fromocaml-goose-value-114once registration is unblocked.