Skip to content

Add estimation of optimal number of training steps and sampling size for fully-visible GRBM#67

Open
VolodyaCO wants to merge 2 commits intodwavesystems:mainfrom
VolodyaCO:sampling-complexity
Open

Add estimation of optimal number of training steps and sampling size for fully-visible GRBM#67
VolodyaCO wants to merge 2 commits intodwavesystems:mainfrom
VolodyaCO:sampling-complexity

Conversation

@VolodyaCO
Copy link
Copy Markdown
Collaborator

This PR adds methods to the GRBM class that compute the required learning rate, data sample size, GRBM sample size and total number of optimisation steps that guarantee convergence of the GRBM, as explained in https://arxiv.org/abs/2306.14969. The GRBM prepares a Boltzmann distribution, so its state can be considered a thermal state of the longitudinal Ising Hamiltonian (see https://arxiv.org/abs/2512.03162 and https://arxiv.org/abs/2511.03796). Therefore, we can use the results of the first paper.

@VolodyaCO VolodyaCO self-assigned this Mar 6, 2026
@VolodyaCO VolodyaCO added the enhancement New feature or request label Mar 6, 2026
@VolodyaCO
Copy link
Copy Markdown
Collaborator Author

I forgot to turn my black formatter off again. Sorry. There are not too many changes to the formatting, though.

Copy link
Copy Markdown
Collaborator

@kevinchern kevinchern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a little longer to give a full review--need to read/skim the references.

In the meantime...

  1. Could you undo the formatting changes? Try to avoid formatting changes in general; formatting changes make it difficult to review code and, separately, breaks commit history e.g., "git blame". If there's an intentional and explicit formatting change, do it in a dedicated formatting-PR and then rebase the current PR on that formatting-PR. This will only fix the readability issue but not the git blame issue.
  2. Can you add equation references in comment like this example?

@VolodyaCO VolodyaCO force-pushed the sampling-complexity branch 2 times, most recently from 870d7f0 to 3f3b999 Compare March 16, 2026 21:28
…to guarantee fully-visible GRBM convergence
@VolodyaCO VolodyaCO force-pushed the sampling-complexity branch from 3f3b999 to cea7dd8 Compare March 16, 2026 21:47
@VolodyaCO
Copy link
Copy Markdown
Collaborator Author

Ok I think I was able to undo all the formatting changes and now finally disabled my formatter. Also added some references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants