Add estimation of optimal number of training steps and sampling size for fully-visible GRBM#67
Open
VolodyaCO wants to merge 2 commits intodwavesystems:mainfrom
Open
Add estimation of optimal number of training steps and sampling size for fully-visible GRBM#67VolodyaCO wants to merge 2 commits intodwavesystems:mainfrom
VolodyaCO wants to merge 2 commits intodwavesystems:mainfrom
Conversation
Collaborator
Author
|
I forgot to turn my black formatter off again. Sorry. There are not too many changes to the formatting, though. |
kevinchern
requested changes
Mar 9, 2026
Collaborator
There was a problem hiding this comment.
Will take a little longer to give a full review--need to read/skim the references.
In the meantime...
- Could you undo the formatting changes? Try to avoid formatting changes in general; formatting changes make it difficult to review code and, separately, breaks commit history e.g., "git blame". If there's an intentional and explicit formatting change, do it in a dedicated formatting-PR and then rebase the current PR on that formatting-PR. This will only fix the readability issue but not the git blame issue.
- Can you add equation references in comment like this example?
870d7f0 to
3f3b999
Compare
…to guarantee fully-visible GRBM convergence
3f3b999 to
cea7dd8
Compare
Collaborator
Author
|
Ok I think I was able to undo all the formatting changes and now finally disabled my formatter. Also added some references. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds methods to the GRBM class that compute the required learning rate, data sample size, GRBM sample size and total number of optimisation steps that guarantee convergence of the GRBM, as explained in https://arxiv.org/abs/2306.14969. The GRBM prepares a Boltzmann distribution, so its state can be considered a thermal state of the longitudinal Ising Hamiltonian (see https://arxiv.org/abs/2512.03162 and https://arxiv.org/abs/2511.03796). Therefore, we can use the results of the first paper.