Skip to content

doctor: match font names the way qt lists them - #3972

Open
cmleon51 wants to merge 1 commit into
duxlabs-dev:masterfrom
cmleon51:fix/font_settings
Open

cmleon51 wants to merge 1 commit into
duxlabs-dev:masterfrom
cmleon51:fix/font_settings

Conversation

@cmleon51

@cmleon51 cmleon51 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR aims to fix the following problem mentioned in Issue #3935: when running the command dms doctor -v and a font that exists in multiple foundries exists it will give out an error and say that the configured font is not in fc-list.

Cause: the problem arises in the fact that in qt qml Qt.fontFamilies() is used while in the go code only the list from fc-list : family is checked and they give out different kind of lists

Fix: in the go code we now build a qt-like font list taking into account the fact that font families may come from different foundries

This PR doesn't aim to solve the other issue mentioned: when a dropdown list has an element that is wider than the given width the elements text will be cut off. The fix lives in dux-qml-common in the following PR: duxlabs-dev/dux-qml-common#33

Claude code was used to generate the code but I take responsibility for it since I have reviewed it, understood it and modified it.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Fixes #3935

Screenshots / video

Before this PR we can see that when selecting RobotoMono Nerd Font [pyrs] dms doctor -v gives a warning:
1793132415559594817

After my PR the warning is gone:
1793132444600126877

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/duxlabs-dev/dux-docs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font settings show installed fonts as missing, and font picker names are truncated

1 participant