Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the following problem mentioned in Issue #3935: when running the command
dms doctor -vand a font that exists in multiple foundries exists it will give out an error and say that the configured font is not infc-list.Cause: the problem arises in the fact that in qt qml
Qt.fontFamilies()is used while in the go code only the list fromfc-list : familyis checked and they give out different kind of listsFix: in the go code we now build a qt-like font list taking into account the fact that font families may come from different foundries
This PR doesn't aim to solve the other issue mentioned: when a dropdown list has an element that is wider than the given width the elements text will be cut off. The fix lives in dux-qml-common in the following PR: duxlabs-dev/dux-qml-common#33
Claude code was used to generate the code but I take responsibility for it since I have reviewed it, understood it and modified it.
Type of change
Related issues
Fixes #3935
Screenshots / video
Before this PR we can see that when selecting

RobotoMono Nerd Font [pyrs]dms doctor -vgives a warning:After my PR the warning is gone:

Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings