Skip to content

feat(theme): add themable tooltip surface colors - #3967

Merged
bbedward merged 6 commits into
duxlabs-dev:masterfrom
hthienloc:feat/themable-tooltip-colors
Oct 28, 2026
Merged

bbedward merged 6 commits into
duxlabs-dev:masterfrom
hthienloc:feat/themable-tooltip-colors

Conversation

@hthienloc

Copy link
Copy Markdown
Member
  • Added tooltipSurfaceColor setting role with preview in SettingsSurfacePreview and an inverseSurface option in SurfaceColorRow.
  • Added Theme.tooltipSurface and Theme.tooltipText (defaulting to dark tooltips in dark mode) and updated DTooltip / Toast.
  • Fixes Add themable tooltip colors (dark tooltips in dark mode) #3933

Setting
image

dark mode
image

light mode

image

@hthienloc

Copy link
Copy Markdown
Member Author

/claude review

Comment thread quickshell/Common/Theme.qml Resolved
@claude

claude Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Claude review

One regression to fix before merge.

  • Theme.inverseSurface dark-mode fallback is no longer inverse, which breaks the new "Inverse Surface" option and DTooltipV2, quickshell/Common/Theme.qml:387
    Checked: Theme tooltip/inverse roles, roleColor wiring, settings spec/data, surface row and preview, Toast/DTooltip usages, dux-qml-common consumers, i18n. Model: claude-opus-5-5.

@bbedward

Copy link
Copy Markdown
Member

This one should probably go in the qml-common spec since it can also apply to tooltips on everything (diles, dcalendar)

@hthienloc
hthienloc marked this pull request as draft October 27, 2026 13:16
@hthienloc

Copy link
Copy Markdown
Member Author

ref duxlabs-dev/dux-qml-common#32

@hthienloc
hthienloc marked this pull request as ready for review October 28, 2026 00:30
@hthienloc

Copy link
Copy Markdown
Member Author

/claude review

@claude

claude Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Claude review

No issues found. The earlier Theme.inverseSurface fallback regression is resolved: the fallback is back to surfaceText, and inverseSurface/inverseOnSurface now come from matugen data.
Checked: the Theme tooltip/inverse roles, the matugen extraction fallbacks, roleColor handling of inverseSurface, moving the settings properties against the shared spec (dux-qml-common bump), the surface row and preview, the Toast/DTooltip switch to tooltipSurface/tooltipText, and i18n. Model: claude-opus-5-5.

@bbedward
bbedward force-pushed the feat/themable-tooltip-colors branch from d062f5c to 253a5d7 Compare October 28, 2026 13:13
@bbedward
bbedward merged commit 8f1a8ad into duxlabs-dev:master Oct 28, 2026
2 checks passed
dux-ci Bot pushed a commit that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add themable tooltip colors (dark tooltips in dark mode)

2 participants