Repository navigation
Fix/3958 lock placement atlas - #3960
Conversation
Every workspace switch changed the lock placement key, so the preparer mapped a hidden window and rendered the whole lock background again, blocking the gui thread for ~450ms per settle. A scrolling wallpaper only changes its crop, so build one luminance atlas per wallpaper and crop it. Refs duxlabs-dev#3958 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The lock itself still decodes synchronously so its first frame is complete, but the hidden placement preparer has no such need. Refs duxlabs-dev#3958 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
/claude review |
Claude reviewOne placement bug in the scroll atlas; the rest looks good.
|
|
/claude review |
Claude reviewThe fix for the earlier transition finding works, but the new source check introduces a placement bug.
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
0075ecd to
4978844
Compare
|
Refactored a bit so this should be less brittle; the lockscreen sampler pulls source (+url) the same way as the lockscreen now; bandaid fixing a second round felt wrong. |
|
/claude review |
Claude reviewNo issues found. The refactor in 4978844 makes both earlier findings obsolete: the sampler now builds its own source URL and reads the image size from its own probe, so it no longer depends on |
port 2.0 (cherry picked from commit ee6e941)
Description
This PR does two main things:
Type of change
Related issues
#3958
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings