Skip to content

fix: Preserve ICU warning context across locales - #701

Merged
klaasnicolaas merged 1 commit into
mainfrom
codex/fix-chinese-icu-placeholders
Aug 10, 2026
Merged

fix: Preserve ICU warning context across locales#701
klaasnicolaas merged 1 commit into
mainfrom
codex/fix-chinese-icu-placeholders

Conversation

@klaasnicolaas

Copy link
Copy Markdown
Member

Summary

  • include the first affected waypoint in both ICU plural branches for route warnings
  • keep Chinese translations valid when Crowdin removes the unsupported one category
  • make multi-warning summaries more useful in every supported language

Why

Simplified Chinese only supports the ICU other plural category. Crowdin therefore removes one during export. Because {first} previously existed only in one, the exported locale lost that required placeholder.

Validation

  • npm run i18n:check
  • npm run lint
  • npm run type
  • npm run build

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deployment failed for project trackdraw with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/dutchdronesquad?upgradeToPro=build-rate-limit

@klaasnicolaas klaasnicolaas added the enhancement Enhancement of the code, not introducing new features. label Aug 10, 2026 — with ChatGPT Codex Connector
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.33% 8325 / 17223
🔵 Statements 47.38% 8876 / 18730
🔵 Functions 48.95% 2171 / 4435
🔵 Branches 38.65% 5076 / 13131
File CoverageNo changed files found.
Generated in workflow #2242 for commit 9e4557c by the Vitest Coverage Report Action

@klaasnicolaas
klaasnicolaas marked this pull request as ready for review August 10, 2026 03:22
Copilot AI lite review requested due to automatic review settings August 10, 2026 03:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates inspector route warning ICU plural messages so that the “first affected waypoint” placeholder ({first}) is available in both plural branches, preventing locale exports (notably zh-CN) from dropping required placeholders and improving multi-warning summaries.

Changes:

  • Add {first} context to the other plural branch for several route warning summaries (steep/hairpin/close-points/spacing-shift/rhythm-break).
  • Adjust wording across supported locales so multi-warning summaries include both {count} and {first} where applicable.
  • Ensure zh-CN remains valid when Crowdin removes the unsupported one category by keeping {first} in other.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lang/zh-CN/inspector.json Adds {first} to other plural branches so Chinese exports remain valid and keep waypoint context.
lang/nl-NL/inspector.json Improves multi-warning summaries by including starting waypoint context in other branch text.
lang/en-US/inspector.json Improves multi-warning summaries by including starting waypoint context in other branch text.
lang/de-DE/inspector.json Improves multi-warning summaries by including starting waypoint context in other branch text.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@klaasnicolaas
klaasnicolaas merged commit 92358db into main Aug 10, 2026
14 of 15 checks passed
@klaasnicolaas
klaasnicolaas deleted the codex/fix-chinese-icu-placeholders branch August 10, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants