fix: Preserve ICU warning context across locales - #701
Merged
Conversation
|
Deployment failed for project trackdraw with the following error: Learn More: https://vercel.com/dutchdronesquad?upgradeToPro=build-rate-limit |
Contributor
Coverage Report
File CoverageNo changed files found. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates inspector route warning ICU plural messages so that the “first affected waypoint” placeholder ({first}) is available in both plural branches, preventing locale exports (notably zh-CN) from dropping required placeholders and improving multi-warning summaries.
Changes:
- Add
{first}context to theotherplural branch for several route warning summaries (steep/hairpin/close-points/spacing-shift/rhythm-break). - Adjust wording across supported locales so multi-warning summaries include both
{count}and{first}where applicable. - Ensure
zh-CNremains valid when Crowdin removes the unsupportedonecategory by keeping{first}inother.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lang/zh-CN/inspector.json | Adds {first} to other plural branches so Chinese exports remain valid and keep waypoint context. |
| lang/nl-NL/inspector.json | Improves multi-warning summaries by including starting waypoint context in other branch text. |
| lang/en-US/inspector.json | Improves multi-warning summaries by including starting waypoint context in other branch text. |
| lang/de-DE/inspector.json | Improves multi-warning summaries by including starting waypoint context in other branch text. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onecategoryWhy
Simplified Chinese only supports the ICU
otherplural category. Crowdin therefore removesoneduring export. Because{first}previously existed only inone, the exported locale lost that required placeholder.Validation
npm run i18n:checknpm run lintnpm run typenpm run build