chore: root npm start launches Expo from packages/mobile - #170
Merged
Conversation
Running npx expo start at the monorepo root silently serves a phantom app (no app config there, default AppEntry requires ../../App which does not exist), Expo Go fails with an App resolution error, and the CLI mutates the root tsconfig.json. This has now happened twice. npm start or npm run mobile at the root now delegates to the mobile workspace with the project's standard port 8083, so the path of least resistance is the correct one.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running
npx expo startat the monorepo root serves a phantom app: there is no app config at the root, so Expo falls back tonode_modules/expo/AppEntrywhoserequire('../../App')fails in Expo Go with an App resolution error. The root-level CLI run also auto-mutates the roottsconfig.json(addsextends: expo/tsconfig.base) and drops a stray.expo/directory. This trap has now been hit twice.What
npm start/npm run mobileat the root now delegate to the@rayhealth/mobileworkspace (npm runs the script with the workspace as cwd) and pass the project's standard--port 8083, so the obvious command does the right thing.Verified: the script prints
Starting project at ...packages/mobileand picks up the mobile env.