Fix/zsh shell detection#22
Merged
Merged
Conversation
duplocloud-matt
commented
Jun 10, 2026
duplocloud-matt
commented
Contributor
- Adds support for zsh based containers like the anthropic reference container
- Fixes startup logic to prevent non-interactive terminals prompting for op signin.
…compatibility and flexibility
add_account could never enroll an account: `op account add` requires the Secret Key (1Password exposes no flag/env for it), and it ran with `</dev/null`, so the Secret Key prompt read EOF and failed with "invalid account key format length 0". It was also gated behind is_terminal_interactive, which is unreliable because the devcontainer CLI allocates a PTY for lifecycle hooks (the gate passes with no human present). Enrollment is inherently interactive, so it now lives solely on the `op-session-reload --interactive` path (the shell rc, where a person just opened a real terminal). on-create now performs a non-interactive session refresh and verifies it with `op whoami` before claiming auth, since op-session-reload also exits 0 on its deferral paths. Also log OP_PASSWD presence/absence during op-session-reload sign-in to help users spot a missing env var. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.