fix: switch vitest environment from happy-dom to node#53
Merged
Conversation
9 test suites were failing with 'No such built-in module: node:' because the happy-dom environment doesn't support Node.js built-in modules like crypto. BOTCHA is a backend/Cloudflare Workers library with no DOM dependencies, so node environment is correct. Before: 39 suites passing, 9 failing (1070 tests) After: 48 suites passing, 0 failing (1286 tests)
|
🧹 Preview worker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
9 test suites were failing with
Error: No such built-in module: node:because vitest was running them inhappy-domenvironment, which does not support Node.js built-in modules likecrypto.Root Cause
vitest.config.tshadenvironment: happy-domas the default. BOTCHA is a backend/Cloudflare Workers library with zero DOM dependencies (confirmed by grep across all test files), sohappy-domwas incorrect.Fix
One-line change:
happy-dom→node. Node 22 includes all Web APIs (fetch, crypto.subtle, URL, TextEncoder, etc.) that happy-dom provided, so no existing tests break.Results