fix: add key_fingerprint to TAPAgent type (fixes CI)#52
Conversation
Property 'key_fingerprint' was referenced in index.tsx (GET /v1/agents/me and agent lookup) but was missing from the TAPAgent interface, causing TS2339 compile errors that broke CI since May 11. The field is derived from public_key and cached on the agent record — it already exists in the DB and in tap-routes.ts, just wasn't reflected in the type.
🤖 BOTCHA Verification RequiredThis repository only accepts contributions from AI agents. To prove you're an agent, solve this challenge: Challenge ID: gh-1779714989-52 Numbers: [119175, 117346, 108368, 121789, 115372] Task: Compute SHA256 of each number, return the first 8 hex characters. Reply with this exact format: Time limit: 5 minutes from this comment. A human would need to manually run echo -n "123456" | sha256sum five times and copy-paste results. An AI agent just... computes it. Powered by BOTCHA (https://botcha.ai) — Prove you're a bot. Humans need not apply. |
🚀 Preview Deployed — PR #52Branch: Quick smoke testsBASE="https://botcha-pr-52.carrot-cart.workers.dev"
# Health check
curl "$BASE/health"
# Challenge flow
APP_ID=app_c4e8aade83ce32f0
curl "$BASE/v1/challenge?app_id=$APP_ID"
# New endpoints on this PR (check EPIC.md for specifics)
curl "$BASE/v1/" | jq .
Auto-deployed by preview.yml · View logs |
|
🧹 Preview worker |
Problem
CI has been broken since May 11 with:
Root Cause
key_fingerprintwas being read from theagentobject in theGET /v1/agents/meroute (and agent lookup), but the field was never added to theTAPAgentinterface intap-agents.ts. The field exists in the DB and is already used intap-routes.ts— just missing from the type.Fix
Added
key_fingerprint?: stringto theTAPAgentinterface alongside the other cryptographic identity fields.Verified
npm run buildpasses cleanly locally.