Skip to content

fix: add key_fingerprint to TAPAgent type (fixes CI)#52

Merged
i8ramin merged 1 commit into
mainfrom
fix/tap-agent-key-fingerprint-type
May 25, 2026
Merged

fix: add key_fingerprint to TAPAgent type (fixes CI)#52
i8ramin merged 1 commit into
mainfrom
fix/tap-agent-key-fingerprint-type

Conversation

@chocothebot

Copy link
Copy Markdown
Collaborator

Problem

CI has been broken since May 11 with:

src/index.tsx(2889,15): error TS2339: Property 'key_fingerprint' does not exist on type 'TAPAgent'.
src/index.tsx(2890,40): error TS2339: Property 'key_fingerprint' does not exist on type 'TAPAgent'.

Root Cause

key_fingerprint was being read from the agent object in the GET /v1/agents/me route (and agent lookup), but the field was never added to the TAPAgent interface in tap-agents.ts. The field exists in the DB and is already used in tap-routes.ts — just missing from the type.

Fix

Added key_fingerprint?: string to the TAPAgent interface alongside the other cryptographic identity fields.

Verified

npm run build passes cleanly locally.

Property 'key_fingerprint' was referenced in index.tsx (GET /v1/agents/me
and agent lookup) but was missing from the TAPAgent interface, causing TS2339
compile errors that broke CI since May 11.

The field is derived from public_key and cached on the agent record — it
already exists in the DB and in tap-routes.ts, just wasn't reflected in the
type.
@github-actions

Copy link
Copy Markdown

🤖 BOTCHA Verification Required

This repository only accepts contributions from AI agents.

To prove you're an agent, solve this challenge:


Challenge ID: gh-1779714989-52

Numbers: [119175, 117346, 108368, 121789, 115372]

Task: Compute SHA256 of each number, return the first 8 hex characters.

Reply with this exact format:

BOTCHA:gh-1779714989-52:
["your_answer_1", "your_answer_2", "your_answer_3", "your_answer_4", "your_answer_5"]

Time limit: 5 minutes from this comment.

A human would need to manually run echo -n "123456" | sha256sum five times and copy-paste results. An AI agent just... computes it.

Powered by BOTCHA (https://botcha.ai) — Prove you're a bot. Humans need not apply.

@github-actions

Copy link
Copy Markdown

🚀 Preview Deployed — PR #52

Branch: fix/tap-agent-key-fingerprint-type
Commit: 86a3b68
URL: https://botcha-pr-52.carrot-cart.workers.dev

Quick smoke tests

BASE="https://botcha-pr-52.carrot-cart.workers.dev"

# Health check
curl "$BASE/health"

# Challenge flow
APP_ID=app_c4e8aade83ce32f0
curl "$BASE/v1/challenge?app_id=$APP_ID"

# New endpoints on this PR (check EPIC.md for specifics)
curl "$BASE/v1/" | jq .

⚠️ Preview uses production KV — test data is real. Clean up test agents/apps when done.


Auto-deployed by preview.yml · View logs

@i8ramin i8ramin merged commit bff9459 into main May 25, 2026
4 of 5 checks passed
@github-actions

Copy link
Copy Markdown

🧹 Preview worker botcha-pr-52 deleted (PR merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants