Codex tracing and install fixes - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat <model>span reconstructed from the completed turn in the rollout JSONL (withexecute_toolchildren for paired tool calls), replacing per-event tool export for Codex and deduplicating repeated cumulative token-usage reports.logfire.json_schemacompanion attribute when flattening nested/array attributes so Logfire rendersgen_ai.input.messages/.output.messagesas structured chat content instead of opaque text.hooks.jsonmechanism (session/subagent/compaction/permission events) alongside the existingnotify-based rollout capture, and fix install/uninstall handling for it (including stripping misconfigured Claude hook entries from Codex's config).chatspan can't be sorted ahead of the user message that triggered it when the rollout and hook clocks disagree.Test plan
pytest(seetests/test_otel_export.py,tests/test_otel_worker.py,tests/test_codex_turn.py,tests/test_codex_hooks_json.py,tests/test_codex_install.py)