Revert "fix: prefix match last search term for multi-dot queries (#139)" - #156
Merged
Conversation
This reverts commit cf492ec. The query-time :* prefix operator added by #139 causes pathological GIN scans: because our fts_data vectors are prefix-dense by design (edge-grams index every prefix of every word), a trailing prefix term like 'prod':* must range-scan and union the posting lists of every lexeme starting with that string. On a large tenant this turned a sub-second search into a 43s query. Prefix expansion belongs at write time in this schema; a follow-up restores multi-dot partial matching via index-side sub-token edge-grams and query-side symbol normalization, without :*. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
arreyder
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are major performance problems with this fix. we need to land a real fix for this edge case that doesn't blow up performance.
This reverts commit cf492ec.
The query-time :* prefix operator added by #139 causes pathological GIN scans: because our fts_data vectors are prefix-dense by design (edge-grams index every prefix of every word), a trailing prefix term like 'prod':* must range-scan and union the posting lists of every lexeme starting with that string. On a large tenant this turned a sub-second search into a 43s query. Prefix expansion belongs at write time in this schema; a follow-up restores multi-dot partial matching via index-side sub-token edge-grams and query-side symbol normalization, without :*.