Repository navigation
fix(secretary): cancel unsent work after owner manual replies - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner's manual reply now cancels earlier unsent secretary work in the same connection and chat, including pending approval. Identity-only owner
business_messageupdates never start generation. Durable, scoped source-revision watermarks suppress delayed older incoming updates across restarts while preserving later incoming work.Connection authority, owner/peer/conversation/policy boundaries and current Receive consent remain enforced. Delivery-attempted, in-flight, unknown and terminal outcomes keep their receipts and existing reconciliation behavior. A review notice confirmed after cancellation is retained so its buttons can still be closed.
Validation: full
task default(format, lint, race tests, both builds),task security-scan, and independent source review passed. Deterministic coverage includes scope isolation, revision ordering/replay, restart, approval callbacks and late notice publication, attempted/unknown delivery preservation, migration, watermark capacity and persistence-size failure. The security scan found no reachable vulnerabilities; one required-module advisory is uncalled.Rollout: deploy this consumer before enabling backend owner-created observations. Persisted state advances to schema 3; preserve the prior binary and matching state backup. Older binaries reject schema 3. Do not blindly downgrade or restore stale state after new activity. This PR publishes an image on merge; runtime deployment and verification are coordinated separately.