Repository navigation
Remove retired native proposal adapter and verify SDK 0.6 - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LO adapter no longer exposes the retired native ProposeBusinessDraft call or its receipt DTO. Flock uses bot-owned approval and delegated sends; no runtime caller uses the removed method.
Replaced the old private SDK 0.2 proposal fixture with getConnection/sendText fixtures recorded by the published Bot SDK 0.6.0 public client. Generation validates receipts, preserves int64 IDs exactly and is deterministic. Legacy SecretaryAction.Reason remains a migration fence; a zero-HTTP regression test confirms old proposal jobs cannot turn into delegated sends. Recovery, owner approval and source tombstones are unchanged.
Validation: task default (tidy, formatting, lint, race tests and both builds), task lint, task tests and task security-scan passed locally. The public SDK recorder and repeat-generation byte check passed. Independent exact-head Astra reviews and required GitHub CI gate the merge; publication of the resulting Flock image remains a separate deployment check.