Repository navigation
fix(secretary): report unavailable knowledge and qualify resumed reads - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegated Secretary runs could successfully connect to MCP with an empty authorized KB catalog, then propose a promise to search instead of an answer. The host now communicates that the knowledge base is unavailable and omits the empty proxy; ordinary replies remain enabled. Existing owner rules, credentials, the three-tool allowlist and approval checks are preserved.
The real pinned-CLI integration fixture now performs a second KB read after session resume through a newly created proxy, rather than only checking its tool inventory. Added regressions cover empty discovery and delegated instructions.
Validation: full Task default (tidy, format, lint, race tests, build) passed; Claude Code 2.1.294 actual-CLI fixture passed; two independent Astra reviews approved exact tree632757d5. The current live Duck credential has no effective knowledge:read: this change does not grant it or substitute product documentation for organizational knowledge.