Repository navigation
[TASK-448] Observe committed HTTP responses and accepted writes - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP observations could report a later attempted 500 after a 200 was already committed, and handled-failure snippets could include bytes the writer rejected. Observe the first final status, accepted write prefixes, streaming/flush/hijack operations, and panic recovery without replacing an already committed response.
Preserve direct optional writer interfaces through httpsnoop 1.1.0. SDK observes outside response-writer middleware; external Unwrap-only capability chains remain unsupported. Backend adoption and privacy changes are tracked separately in TASK-439.
The required security scan found five existing x/net HTTP/2 advisories, including GO-2026-6617. Upgrade x/net to 0.60.0 with its required companion versions. This requires Go 1.26; raise the minimum to patched Go 1.26.10, document the consumer migration and test 1.26.10/1.27.3 with automatic toolchain switching disabled in CI. Release as v0.5.0 to expose the compatibility change.
Validation: gofmt clean; full go vet and go test -race passed on Go 1.26.10; pinned govulncheck on that minimum reports no vulnerabilities. Regression coverage includes short/error writes, bounded capture, informational/final statuses, real HTTP 103→201, optional interfaces, inner Unwrap/controller operations, and panic before/after commit or hijack. Astra reviewed all nine final file hashes. Fresh complete CI is required for this head.
TASK-448