Skip to content

build(deps): bump google.golang.org/grpc from 1.83.2 to 1.84.0 in the go-minor group across 1 directory - #11

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/go-minor-319900d126
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/go-minor-319900d126

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the go-minor group with 1 update in the / directory: google.golang.org/grpc.

Updates google.golang.org/grpc from 1.83.2 to 1.84.0

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.84.0

Behavior Changes

  • stats/otel: The grpc.lb.pick_first.* metrics have been removed and replaced with grpc.subchannel.* metrics. See gRFC A94 for more details. (#9215)

New Features

  • xds: Add support for contains_match in route header matchers. (#9223)

Bug Fixes

  • client: Fix a bug where a ClientConn could get permanently stuck in IDLE when an RPC was canceled during stream creation. Previously, such cancellations triggered stream cleanup twice, corrupting the channel's idleness state and causing subsequent RPCs to fail with deadline exceeded errors. (#9191)
  • client: Fix a bug where non-gRPC HTTP responses ending with an empty DATA frame failed the RPC with status code Internal instead of preserving the HTTP-mapped status code and response body. (#9217)
  • credentials: Validate metadata returned by per-RPC credentials, failing the RPC with status code Internal if invalid keys or values are found. Previously, invalid metadata from credentials was sent to the server in outgoing HTTP/2 requests. (#9202)
  • credentials/sts: Prevent potential token leakage by disallowing HTTP redirects during STS token exchange. Previously, 3xx redirects were followed automatically, replaying the request body containing authentication tokens to the redirect destination. (#9299)
  • randomsubsetting: Ignore endpoints that contain no addresses. Previously, this could cause the policy to panic while computing hashes. (#9259)
  • stats/otel: Ensure method names are populated in trace spans when metrics are disabled. Previously, running with tracing enabled and metrics disabled resulted in server trace spans lacking the RPC method name (recording only "Recv."). (#9262)
  • transport: Return io.ErrUnexpectedEOF when EOF is encountered after partial header or message body reads. Previously, partial reads could return a plain io.EOF, failing to distinguish truncated data from a clean end of stream. (#9204)
  • transport: Validate metadata supplied by balancers (in PickResult.Metadata) and resolver addresses, failing the RPC with status code Internal if invalid keys or values are found. Previously, invalid metadata from these sources was sent to the server in outgoing HTTP/2 requests. (#9203)
  • xds: Fix a rare corner case that could prevent a cluster from being removed when it is no longer in use. (#9140)
  • xds: Fix panic during route matching for routes containing header matchers with empty exact_match strings. (#9223)
  • xds: Reject routes containing header matchers with empty prefix_match or suffix_match strings. Previously, this caused a panic during route matching. (#9223)
  • xds: Fix EDS drop policies being applied at a much lower rate than configured due to an integer overflow. (#9257)
  • xds: Reject EDS resources containing drop policies with unsupported denominators. Previously, such resources caused the client to panic when calculating drop rates. (#9218)
  • xds/rbac: Reject RBAC configurations containing nested Principal or Permission rules with :scheme or grpc- prefixed header matchers. Previously, such configurations could cause DENY policies to fail open. (#9258)
  • xds/rbac: Rewrite host header matchers to :authority in nested Principal and Permission rules. Previously, this rewrite only applied to top-level rules, causing nested host matchers to never match incoming requests and DENY policies to fail open. (#9258)
  • xds/rbac: Reject CidrRanges with an unset prefix length. Previously, an omitted prefix_len field caused a panic during RBAC configuration parsing. (#9250)

Performance Improvements

  • transport: Avoid a heap allocation when flushing shared write buffers. (#9233)
  • credentials/alts: Support dynamic frame size negotiation and add the GRPC_GO_EXPERIMENTAL_ALTS_MAX_FRAME_SIZE environment variable (default 4KiB, max 512KiB) to configure the maximum ALTS record frame size. (#9268)
Commits

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot @github

dependabot Bot commented on behalf of github Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, go. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@DuckBugAgent DuckBugAgent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Раунд 1 из 1 · полное ревью · Влияние бампа на go-floor и API

Ревью

Замечаний по изменениям не нашёл.

  • Коротко: Минорный бамп grpc 1.83.2 → 1.84.0 не трогает floor модуля и не задевает используемый серверный API — возражений нет.
  • Риски/вопросы:
    • Главный риск, прямо описанный в каноне репозитория (.github/dependabot.yml: «expect it to offer the grpc upgrade... that one pulls x/net past go 1.26 and takes the module floor with it»), здесь не реализуется: go 1.25.13 и golang.org/x/net v0.58.0 в go.mod не изменились, а Test (Go 1.25.13) с GOTOOLCHAIN: local зелёный — значит собственная go-директива grpc 1.84.0 floor не поднимает.
    • Из go.sum выпали otel/go-logr/uuid/xxhash — это следствие того, что grpc 1.84 больше не тянет их в обрезанный граф модуля. Проверено не на глаз: шаг «Verify module metadata» в .github/workflows/go-checks.yml делает go mod tidy + git diff --exit-code -- go.mod go.sum, и он зелёный, то есть go.sum ровно совпадает с выводом tidy. Локально перепроверить не смог — в среде нет тулчейна Go.
    • Поведенческие изменения 1.84.0 из release notes (валидация метаданных от per-RPC credentials и балансировщиков, залипание ClientConn в IDLE, STS-редиректы) — клиентские. Grep по репозиторию: grpc используется только в integrations/grpc/interceptor.go (Unary/StreamServerInterceptor, codes/metadata/peer/status), ни grpc.NewClient/Dial, ни PerRPCCredentials, ни stats/opentelemetry нигде не импортируются — этот код перечисленные изменения не затрагивают.
    • Диff соответствует заголовку PR: изменены ровно grpc и его транзитивный genproto/googleapis/rpc, посторонних бампов нет. Второй модуль .github/tools/go.mod (govulncheck) этот PR не трогает.
    • Вопрос вне диффа, не блокирующий: комментарий dependabot сообщает, что меток dependencies и go нет в репозитории. Это настройка GitHub, в этой ветке не чинится — метки нужно создать отдельно, иначе предупреждение будет повторяться на каждом PR.
    • Security Scan зелёный, но по собственному комментарию в go-checks.yml он не воспроизводим от SHA (тулчейн stable + база advisories тянется в рантайме), так что зелёный статус сегодня не гарантирует того же завтра.

Арбитр ревью: остановлено — блокирующего не осталось, PR готов к мерджу человеком.

Причина: Раунд 1/1, ревьювер вернул вердикт ok без единой находки: блокирующих (BLOCKER/MAJOR) нет. Минорный бамп grpc 1.83.2→1.84.0 не меняет floor модуля и не затрагивает используемый API; жалоба dependabot на отсутствующие лейблы — вопрос конфигурации репозитория, а не кода PR.

Bumps the go-minor group with 1 update in the / directory: [google.golang.org/grpc](https://github.com/grpc/grpc-go).


Updates `google.golang.org/grpc` from 1.83.2 to 1.84.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.83.2...v1.84.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.84.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump google.golang.org/grpc from 1.83.2 to 1.84.0 in the go-minor group build(deps): bump google.golang.org/grpc from 1.83.2 to 1.84.0 in the go-minor group across 1 directory Oct 23, 2026
@dependabot
dependabot Bot force-pushed the dependabot/go_modules/go-minor-319900d126 branch from ba6265b to 15465b5 Compare October 23, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant