fix: restore Windows UI Automation elements - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Generic.List[object]with.ToArray()before returning it from PowerShell.Infinitynever corrupts the JSON transport.EPIPEand defer to the authoritative helper close/result.Root cause
Windows PowerShell 5.1 throws
System.ArgumentException: Argument types do not matchwhen@(...)directly wraps this generic list. The helper's catch converted that exception into an empty element array, so every semantic Windows observation returnedelementTotal: 0.Once the list was correctly returned, CI also exposed UIA's non-finite virtual bounds: PowerShell serialized those as a bare
Infinitytoken. The helper now preserves the semantic element and omits only unusable bounds.Validation
EPIPEregression: 30 consecutive targeted runs passed.npm run check: 112 passed.npm run pack:dry: package 0.5.9 generated successfully.Fixes #1