Fix Windows/UEFI handling for non-ZST sentinels in distributed slices#126
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Apr 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows (and UEFI),
distributed_slicerelies on ZST statics (()and[T; 0]) occupying exactly 0 bytes in PE/COFF grouped sections, but this is not guaranteed by the language and breaks with some codegen backends (#125). ZST sections are also fragile in other ways: rust-lld crashes on empty slices (#114) and MinGW's linker garbage-collects them (#25).This PR replaces the ZST sentinels with non-ZST types of known size --
MaybeUninit<T>for slice boundaries andisizefor dupcheck boundaries -- then adjusts the runtime arithmetic to account for the sentinel bytes:wrapping_add(2)for dupcheck andstart.add(1)to skip the start sentinel.All changes are behind
cfg(windows/uefi)and do not affect other platforms.Closes #125