Support creation of rust::Str from consteval utf8 checked string literal#1704
Open
wsxarcher wants to merge 3 commits intodtolnay:masterfrom
Open
Support creation of rust::Str from consteval utf8 checked string literal#1704wsxarcher wants to merge 3 commits intodtolnay:masterfrom
wsxarcher wants to merge 3 commits intodtolnay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a C++20-only path for constructing rust::Str from UTF-8 string literals. The _utf8 literal validates the input at compile time using consteval function and then calls the unsafe version of constructing a str from rust to avoid double checking it (https://doc.rust-lang.org/std/str/fn.from_utf8_unchecked.html).
This is useful for creating literal Str without utf8 runtime checking overhead.
It can be especially useful in non exception code such as Chromium as extra utf8 check would have to be done outside the cxx library as a potential failure will result in abort, bringing the checks for static literals from 2 to 0.
Working example:
rust::Str var{u8"Valid👍"_utf8};This will not compile:
rust::Str var{u8"Invalid\xff"_utf8};