chore: shrink datatransferproject/dev image and fix bundled Gradle mismatch - #1505
Merged
Conversation
vipulkala95
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datatransferproject/devimage bundled Gradle 8.10.2, which is never invoked (the entrypoint is./gradlew, wrapper-pinned to 6.9.2) and can't even build this project --build.gradleuses the legacymavenplugin, removed in Gradle 7+.eclipse-temurin:11-jdk-jammy, with the wrapper-pinned Gradle 6.9.2 resolved and cached into an image layer atdocker buildtime, rather than downloaded on firstdocker run.Notable decisions / tradeoffs
gradle:*tag: the project's build only works under Gradle 6.9.2 (wrapper-pinned). No officialgradle:6.9.2-*variant is smaller than the current image anyway (727MB) -- baking the correct wrapper distribution onto a bare JDK base beats bundling a whole (and in this case wrong) Gradle install.eclipse-temurinis not a new trust surface: confirmed via matchingJAVA_HOME, layer signatures, and entrypoint script fingerprint thatgradle:8.10.2-jdk11was already built on Temurin -- this just removes a layer of indirection around the same JDK.docker run: resolving at build time keeps the image self-contained/offline-capable and still respectsgradle-wrapper.propertiesas the single source of truth -- no version hardcoded a second time, so Docker's build cache naturally invalidates and re-fetches if the wrapper version changes.GRADLE_USER_HOME/volume path unchanged: still/home/gradle/.gradle, sodocker-compose.ymland any already-warmedgradle-cachevolumes keep working untouched.Test plan
docker buildsucceeds./gradlew --versionresolves offline (--network none) against a fresh named volume./gradlew taskssucceeds end-to-end with network availabledocker images: 708MB -> 631MB