Enforce redirect URI scheme policy at authorization time - #281
Open
aaronjae22 wants to merge 4 commits into
Open
Enforce redirect URI scheme policy at authorization time#281aaronjae22 wants to merge 4 commits into
aaronjae22 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #279 (PR 2/3)
This PR adds the missing scheme check to
ActivityPubOAuth2Validator.validate_redirect_uri, and writes the redirect-scheme policy intosettings/base.pyinstead of inheriting django-oauth-toolkit's invisible default.The allowed list stays ['http', 'https'], so every redirect URI accepted today is still accepted.
validate_redirect_urikeepssuper()'s allow-list check as the first gate, then tests the URI's scheme againstoauth2_settings.ALLOWED_REDIRECT_URI_SCHEMES.Returning False makes oauthlib raise
InvalidRedirectURIError, a fatal client error, so DOT renders an error page rather than redirecting. A rejected URI is never used as a redirect target — no open-redirect surface.