Remove ?auth_token= URL auth path; header + demo-scoped session only - #265
Merged
Conversation
…ication non-normative path
…ying on session auth
lisad
approved these changes
Jun 15, 2026
|
|
||
| #### 2. URL Parameter (Testing) | ||
| ```http | ||
| GET /api/actors/1/?auth_token=your-oauth-token-here HTTP/1.1 |
Member
There was a problem hiding this comment.
I don't think this was harmful in a testbed and needed to be removed, but I also don't think it's harmful to remove
Base automatically changed from
aaronaej/implement-demo-side-for-authorization-redirect-includes-activitypub_actor
to
main
June 16, 2026 20:07
aaronjae22
marked this pull request as ready for review
June 16, 2026 20:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #264
This PR completely reviews
OptionalOAuth2Authentication.The auth class now accepts a portability token two ways:
Authorization: Bearerheader?auth_token=query-string path is removed entirely.For testing (and demoing) purposes I previously created a third auth path that included
?auth_token=in the URLs. With this update, the session path already covers the demo without that exposure.I deleted
_authenticate_with_url_token. The session path stays but is demo-scoped by construction (only the demo flow populates the session; cookie-bound; re-validated each request;?public_only-suppressed), so it needs no flag or config. The token-validation step is kept as_resolve_valid_access_token. The demooauth_token_exchange.htmlauthenticates via session (no token in any URL).