Repository navigation
refactor(dispatch): delete dead _process_split_pipeline cluster from orchestrator - #41
Merged
Merged
Conversation
…orchestrator FileProcessor owns the split flow since the split-EDI fix, so the 13-method cluster only reachable from DispatchOrchestrator._process_split_pipeline (zero production callers) is redundant. Removes _send_pipeline_file and the tests that existed solely for it; multi-backend partial-failure coverage now lives in FileProcessor's send tests. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Since
FileProcessornow owns the split flow (see #40),DispatchOrchestrator._process_split_pipelineand the 12 methods only it could reach have zero production callers. This removes the dead cluster (~419 lines):_process_split_pipeline,_extract_split_files,_record_split_send_failure,_record_send_failure,_format_send_error,_log_success_with_invoices,_run_validation_pipeline,_apply_conversion,_execute_conversion_step,_set_checksum_for_result,_normalize_validation_output,_apply_validation_outcome,_send_pipeline_file.Also removes
TestSendPipelineFile(3 tests for the deleted method); the multi-backend partial-failure behavior it covered is preserved inFileProcessor's send tests where that logic now lives.Live methods (
_process_file_with_pipeline,_detect_enabled_backends,_build_processing_context,process_file, …) are untouched.