Skip to content

feat: add !reference and !reference-all shorthands#19

Merged
ryodine merged 2 commits into
mainfrom
feat/shorthand
Mar 16, 2026
Merged

feat: add !reference and !reference-all shorthands#19
ryodine merged 2 commits into
mainfrom
feat/shorthand

Conversation

@ryodine

@ryodine ryodine commented Mar 14, 2026

Copy link
Copy Markdown
Collaborator

@ryodine ryodine marked this pull request as ready for review March 14, 2026 04:12
@ryodine ryodine requested review from Copilot and dsillman2000 March 14, 2026 04:12
@ryodine ryodine self-assigned this Mar 14, 2026
@ryodine ryodine added the enhancement New feature or request label Mar 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds scalar “shorthand” forms for YAML !reference and !reference-all tags so they can be used directly with a string value (e.g., !reference "file.yaml"), and updates the README spec-status badge.

Changes:

  • Add scalar shorthand custom tag resolvers for !reference and !reference-all.
  • Replace the previous “illegal on scalar” behavior for these tags with shorthand parsing.
  • Update README spec badge version/link.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/Reference.ts Adds scalar shorthand resolver for !reference and registers it in referenceTags.
src/ReferenceAll.ts Adds scalar shorthand resolver for !reference-all and registers it in ReferenceAllTags.
README.md Updates spec-status badge version/link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ReferenceAll.ts Outdated
Comment thread src/ReferenceAll.ts
Comment thread README.md
Comment thread src/Reference.ts Outdated
Comment thread src/Reference.ts
@ryodine ryodine changed the base branch from feat/ignore to main March 15, 2026 03:18
@ryodine

ryodine commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot AI commented Mar 15, 2026

Copy link
Copy Markdown

@ryodine I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you.

…ference/!reference-all shorthands (#21)

* Initial plan

* fix: use onError callback in scalar shorthands, add tests, update README

Co-authored-by: ryodine <5068378+ryodine@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ryodine <5068378+ryodine@users.noreply.github.com>

@dsillman2000 dsillman2000 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the unit tests

@ryodine ryodine merged commit 0472bad into main Mar 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants