Repository navigation
fix: TUI type filter visibility and private vault PAT prompt - #32
Merged
Merged
Conversation
Add 't' keybind to hotkey bar so users know the filter exists. Always display current type filter in status line, highlighted when active.
- Memoize filteredPackages in Discover to prevent cursor reset on every render - Add token step in Add Vault flow when vault is marked private - Prompt for PAT inline when sync fails on a private vault (auth/404) - Mask token input with asterisks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tkeybind to hotkey bar so users know type filtering exists in Discovertby memoizingfilteredPackagestokenstep in Add Vault flow)Test plan
t filter typeshows in hotkey bartto cycle filters → verify status line shows current filter (e.g.type: skills)tthen arrow down → verify list scrolls without flickeringato add vault → answeryto private → verify PAT prompt appearssto sync with a private vault missing token → verify PAT prompt appears