Repository navigation
fix(stellar-sdk-helpers): return total fee from prepareSorobanTx - #1226
Merged
Conversation
|
@elizabethklien3-pixel is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
directorfloo
force-pushed
the
Chorestellarsdkhelperscleanupafeecommentthatcontradictsthecodeanunderstatedreturnedfeeandanunreachablefallback
branch
2 times, most recently
from
October 25, 2026 00:40
6d1b5f9 to
2bd4eaa
Compare
Contributor
Author
|
please merge everything fixed |
collinsezedike
force-pushed
the
Chorestellarsdkhelperscleanupafeecommentthatcontradictsthecodeanunderstatedreturnedfeeandanunreachablefallback
branch
from
October 25, 2026 16:28
4b77547 to
eb58669
Compare
collinsezedike
changed the title
collinsezedike
force-pushed
the
Chorestellarsdkhelperscleanupafeecommentthatcontradictsthecodeanunderstatedreturnedfeeandanunreachablefallback
branch
from
October 25, 2026 16:48
eb58669 to
81e0ece
Compare
collinsezedike
approved these changes
Oct 25, 2026
collinsezedike
left a comment
collinsezedike
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the updates, @directorfloo. The fee documentation now matches the implementation and all required checks pass. This is ready to merge; please consider picking up another open issue.
Collaborator
|
Thank you for your contribution, @directorfloo; if you have a moment, starring the repository would help the project reach more people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitKeeperOperationattempt comment to 0-indexed.prepareSorobanTxand document it.vaults.ts.Verification
pnpm --filter @meridian/stellar-sdk-helpers test(576 passed)pnpm --filter @meridian/stellar-sdk-helpers typecheckCloses #1062