Repository navigation
Conversation
|
@chuks68 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@chuks68 is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
c505153 to
a32819d
Compare
collinsezedike
left a comment
collinsezedike
left a comment
There was a problem hiding this comment.
The retry state and translations are correct, and the tests pass. pnpm format:check fails on apps/web/src/pages/AdminLogin.tsx; run pnpm prettier --write apps/web/src/pages/AdminLogin.tsx and push. All other required checks pass.
collinsezedike
left a comment
collinsezedike
left a comment
There was a problem hiding this comment.
@chuks68 the retry and error states are correct and the translations are covered. Lint & Typecheck still fails on the Prettier check for AdminLogin.tsx (lines 96-98 and 133); run pnpm prettier --write apps/web/src/pages/AdminLogin.tsx and push. The E2E Tests failure is the withdraw spec against the live API, not this change.
| The connected wallet doesn't match the vault's admin address. This | ||
| page is only accessible to the vault admin. | ||
| </p> | ||
| <h1 className="text-xl font-bold text-paper">{t("admin.notAuthorized")}</h1> |
There was a problem hiding this comment.
Prettier splits this line; run pnpm prettier --write apps/web/src/pages/AdminLogin.tsx. The same check also joins the readError paragraph at lines 96-98.
This branch has not been deployed
2 participants
this pr closes #1065
Summary
Resolves two issues in the
/admingate:fetchVaultAdminpromise rejections were funneled into{ authorized: false }, showing an unauthorized message to legitimate admins when RPC calls timed out or failed. This change tracks read errors separately and renders a dedicated error screen with a retry button and switch-wallet action.AdminLogin.tsxwith translations viauseTranslation(), utilizing existing keys (admin.connectPrompt,admin.notAuthorized) and addingadmin.access,admin.readError,admin.switchWallet,admin.connected, andadmin.loadingacrossen.jsonandfr.json.walletConnect.chooseWalletkey to the wallet picker menuaria-labelinWalletConnect.tsx.Verification
AdminLogin.test.tsxassert retry behavior on RPC read failure, non-admin blocked behavior, and rendering of localized strings in French (fr).WalletConnect.test.tsxassert thewalletConnect.chooseWalletaccessible label.@meridian/webtest suites passed (vitest run).