Repository navigation
fix(blend-adapter): guard subtraction against negative deltas - #1182
collinsezedike merged 1 commit into
Conversation
|
@laxjovial is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@laxjovial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
The guarded subtraction and the two new tests are correct. Amend the commit subject, which is 75 characters and fails the required Commit Messages check, for example fix(blend-adapter): guard subtraction against negative deltas. Also unindent the PR body so Closes #1106 is parsed; the current four-space indent turns it into a code block and GitHub does not link the issue. The PR title is truncated at ov…; complete or shorten it.
9c65c11 to
983c6b4
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
@laxjovial Thank you for your contribution. If you are interested, there are more open issues to pick up.
|
@laxjovial Thank you for your contribution. If you found Meridian useful, please star the repository: https://github.com/drydocs/meridian. |
Summary
checked_sub, panicking withContractError::Overflow.Test plan
cargo test -p meridian-blend-adapterpasses underpackages/contractsCloses #1106