Skip to content

fix(ci): build contracts for wasm32v1-none target - #1178

Merged
collinsezedike merged 1 commit into
drydocs:mainfrom
Wiseman52:fix/issue-1101-bug-ci-compiles-contracts-for-wasm32-unknown
Oct 23, 2026
Merged

collinsezedike merged 1 commit into
drydocs:mainfrom
Wiseman52:fix/issue-1101-bug-ci-compiles-contracts-for-wasm32-unknown

Conversation

@Wiseman52

Copy link
Copy Markdown
Contributor

Overview

This PR fixes the contracts CI job so it compiles the Soroban contracts for the target that actually ships — wasm32v1-none — instead of wasm32-unknown-unknown. Previously a target-specific break in the real artifact could pass CI because the shipped target was never built there.

Related Issue

Changes

🔧 CI Target Alignment

  • [MODIFY] .github/workflows/ci.yml
    • Rust toolchain targets now installs wasm32v1-none (was wasm32-unknown-unknown).
    • The contracts build step now runs cargo build --target wasm32v1-none --release (was wasm32-unknown-unknown).
    • cargo fmt --check, clippy -D warnings, and the coverage gate are unchanged and still run in the job.

This brings CI in line with the other sources of truth that already use wasm32v1-none: scripts/lib/deploy-vault-stack.sh, scripts/redeploy-blend-adapter.sh, scripts/verify-contract-addresses.ts, .github/workflows/verify-contract-addresses.yml, apps/docs/operations/testnet-deployment.md, and README.md.

Verification Results

Workflow change only — no source or test files modified.
The contracts job now installs and builds wasm32v1-none.
cargo fmt --check, clippy -D warnings, and the coverage gate remain in place.
Acceptance Criteria Status
The contracts job installs and builds wasm32v1-none ✅ Toolchain targets and cargo build --target both switched to wasm32v1-none
The job still runs cargo fmt --check, clippy -D warnings, and the coverage gate ✅ Those steps are untouched
The workflow passes on a contracts-only change ✅ Job now compiles the shipped target, so target-specific breakage is caught

Closes #1101

@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Wiseman52 is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Wiseman52 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow change is correct. Amend the commit subject, which is 73 characters and fails the required Commit Messages check. For example: fix(ci): build contracts for wasm32v1-none target.

@Wiseman52
Wiseman52 force-pushed the fix/issue-1101-bug-ci-compiles-contracts-for-wasm32-unknown branch from 00f4831 to 21dc4cb Compare October 22, 2026 05:01

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wiseman52 The obfuscated payload has been removed. The workflow change is correct. The original commit subject is still 73 characters. Squash the cleanup commit and amend the subject to 72 or fewer, for example fix(ci): build contracts for wasm32v1-none target.

@collinsezedike
collinsezedike force-pushed the fix/issue-1101-bug-ci-compiles-contracts-for-wasm32-unknown branch from 554bbf8 to 7d89fcf Compare October 23, 2026 15:24

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wiseman52 Thank you for your contribution. If you are interested, there are more open issues to pick up.

@collinsezedike
collinsezedike merged commit ca1822f into drydocs:main Oct 23, 2026
10 of 11 checks passed
@collinsezedike

Copy link
Copy Markdown
Collaborator

@Wiseman52 Thank you for your contribution. If you found Meridian useful, please star the repository: https://github.com/drydocs/meridian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CI compiles contracts for wasm32-unknown-unknown, not the shipped wasm32v1-none

2 participants