Repository navigation
fix(ci): build contracts for wasm32v1-none target - #1178
collinsezedike merged 1 commit into
Conversation
|
@Wiseman52 is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Wiseman52 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
The workflow change is correct. Amend the commit subject, which is 73 characters and fails the required Commit Messages check. For example: fix(ci): build contracts for wasm32v1-none target.
00f4831 to
21dc4cb
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
@Wiseman52 The obfuscated payload has been removed. The workflow change is correct. The original commit subject is still 73 characters. Squash the cleanup commit and amend the subject to 72 or fewer, for example fix(ci): build contracts for wasm32v1-none target.
554bbf8 to
7d89fcf
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
@Wiseman52 Thank you for your contribution. If you are interested, there are more open issues to pick up.
|
@Wiseman52 Thank you for your contribution. If you found Meridian useful, please star the repository: https://github.com/drydocs/meridian. |
Overview
This PR fixes the
contractsCI job so it compiles the Soroban contracts for the target that actually ships —wasm32v1-none— instead ofwasm32-unknown-unknown. Previously a target-specific break in the real artifact could pass CI because the shipped target was never built there.Related Issue
Changes
🔧 CI Target Alignment
.github/workflows/ci.ymltargetsnow installswasm32v1-none(waswasm32-unknown-unknown).cargo build --target wasm32v1-none --release(waswasm32-unknown-unknown).cargo fmt --check,clippy -D warnings, and the coverage gate are unchanged and still run in the job.This brings CI in line with the other sources of truth that already use
wasm32v1-none:scripts/lib/deploy-vault-stack.sh,scripts/redeploy-blend-adapter.sh,scripts/verify-contract-addresses.ts,.github/workflows/verify-contract-addresses.yml,apps/docs/operations/testnet-deployment.md, andREADME.md.Verification Results
contractsjob installs and buildswasm32v1-nonetargetsandcargo build --targetboth switched towasm32v1-nonecargo fmt --check,clippy -D warnings, and the coverage gateCloses #1101