Repository navigation
docs: correct migration slippage cap to 500 bps - #1150
collinsezedike merged 1 commit into
Conversation
|
@Starr-p is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Starr-p Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
The content is correct against packages/stellar-sdk-helpers/src/migration-keeper.ts. The only failing check is the commit header, which is 73 characters (the repo limit is 72). Please shorten it to 72 or fewer and this is good to go.
50c94e0 to
66c978f
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
@Starr-p Thank you for your contribution. If you are interested, there are more open issues to pick up.
|
@Starr-p Thank you for your contribution. If you found Meridian useful, please star the repository: https://github.com/drydocs/meridian. |
Overview
This PR corrects the migration keeper operations documentation so it reflects the post-#557 slippage cap.
apps/docs/operations/migration-keeper.mdstill described the pre-#557 behavior (10,000bps ceiling,9999treated as functionally unlimited), which would lead an operator to submit values that now revert withInvalidSlippageBps. The page is updated to match the contract'sMAX_ADMIN_SLIPPAGE_BPS = 500and to align withenvironment-variables.mdandvault-contract.md.Related Issue
Changes
📄 Migration Keeper Docs
apps/docs/operations/migration-keeper.mdmigrate_adapterslippage bound from<= 10000to the contract's500bps cap (MAX_ADMIN_SLIPPAGE_BPS), noting that values above it revert withInvalidSlippageBps.10000is rejected and that9999is accepted as functionally unlimited; the loader enforces the same500bps cap.10000/9999accepted-value references so the page matchesenvironment-variables.mdandvault-contract.md.Verification Results
migration-keeper.mdstates the500bps cap and matchesenvironment-variables.mdandvault-contract.md500bps and cross-checked against both pages10000/9999as an accepted valueCloses #1096