Repository navigation
[Bug] Accrual keeper cannot fail open during a state-store outage #1132
Description
Summary
The accrual keeper documents a deliberate fail-open when the prior submission state is unknown, so a store outage cannot leave every vault's cached TVL/APY stale. But the very next step takes a submission lease through the same state store, so when the store is unreachable acquire returns an error and the adapter is skipped, producing exactly the halted accrual the fail-open is meant to prevent.
Tasks
packages/stellar-sdk-helpers/src/accrual-keeper.ts:461-492logs and proceeds whenprior.state === "unknown", then callsSubmissionLease.acquirewith the samestateStore.packages/stellar-sdk-helpers/src/keeper-state.ts:335-347returns{ error: "submission state store unavailable" }fromclaimwhen the store cannot be reached.packages/stellar-sdk-helpers/src/accrual-keeper.ts:483-492pushes the adapter intoskippedon that error.- Either keep accruing without the lease when the store is unavailable, or correct the comment so the documented behavior matches the code.
Scope
| Field | Value |
|---|---|
| Area | SDK |
| Protocol affected | None |
| Network | testnet and mainnet |
| Breaking change? | No |
Acceptance Criteria
- The behavior during a state-store outage matches the documented fail-open intent, or the documentation is corrected and the outage path is tested.
-
pnpm lint && pnpm typecheck && pnpm testpass.
Additional Context
Found in a repository-wide code audit on 2026-10-18 and re-verified against the source at 66fad4d.
Star the repo
Please star this repository before picking up this issue. It is a small ask that meaningfully helps the project reach more people.
Activity
liutingqiu commentedon Oct 18, 2026
@liutingqiu has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @liutingqiu to this issue.
The-Big-Danny commentedon Oct 18, 2026
@The-Big-Danny has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @The-Big-Danny to this issue.
drips-wave commentedon Oct 18, 2026
Congratulations, @liutingqiu! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @liutingqiu: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@liutingqiu's PR #1175 was approved and merged by @collinsezedike.
🏆 @liutingqiu: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (35 total points). Track your full progress on GrantFox.
👏 Great work, @liutingqiu! Keep contributing to drydocs.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @liutingqiu as part of the Stellar Wave Program's 10th Wave 🥳
😎 @liutingqiu: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.