Conversation
…jected The -bare and -bytealign guards tested appendable alone, but -catable only implies appendable once SanitizeParams runs, so the README's `-bare -catable` recipe was rejected; the rejection returned from main and exited 0 with no output. Accept -catable as the prerequisite it is and exit 1 when the guard fires.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's concatenation recipe is
brotli -c -bare -catable -w22 file, but the CLI rejected it: the-bareand-bytealignguards testappendablealone, and-catableonly impliesappendableonceSanitizeParamsruns, after the guards. The rejection alsoreturned frommain, so the process printed "bare streams only supported when catable or appendable!", wrote nothing and exited 0. A shell pipeline collected an empty part and the combined stream decoded to the first input alone.-bare -catableand-bytealign -catableare now accepted, matching the message and the README, and the rejection exits 1.-bareor-bytealignwithout either prerequisite is still refused.Tests:
cargo fmt --check,cargo test,cargo test --docandcargo test --features portable-floatpass. Ontestdata/ukkonooa,-bare -catable,-bare -appendableand-bytealign -catablenow emit 85, 82 and 86 bytes;-barealone exits 1.