Conversation
BROTLI_NUM_HISTOGRAM_DISTANCE_SYMBOLS was defined twice: unconditionally 544 in enc/constants.rs and privately in enc/histogram.rs, where only that copy shrank to 520 under disallow_large_window_size. The histogram array took the private value while every bound took the public one, so the encoder indexed one past the end. Keep one feature-aware definition.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test --features disallow_large_window_sizepanics inBrotliOptimizeHuffmanCountsForRlewithindex out of bounds: the len is 520 but the index is 520(integration_tests::test_ukkonooa), and so does compressing ordinary text with that feature on.BROTLI_NUM_HISTOGRAM_DISTANCE_SYMBOLSwas defined twice:puband unconditionally 544 inenc/constants.rs, and privately inenc/histogram.rs, where only that copy shrank to 520 under the feature.HistogramDistance::data_took the private value while every bound took the public one.This keeps one feature-aware definition in
constants.rsand imports it fromhistogram.rs. The default build still reads 544.Tests:
cargo test --features disallow_large_window_sizenow passes (42 + 101).cargo fmt --check,cargo test,cargo test --docandcargo test --features portable-floatpass as before.