[Sqlite]: Skip undefined JOIN ON / ORDER BY / GROUP BY from sql.if(false) - #6177
Open
bun-unsafe wants to merge 1 commit into
Open
[Sqlite]: Skip undefined JOIN ON / ORDER BY / GROUP BY from sql.if(false)#6177bun-unsafe wants to merge 1 commit into
bun-unsafe wants to merge 1 commit into
Conversation
.sql.if(false) returns undefined. WHERE already drops it, but JOIN kept the table without ON (cartesian product) and ORDER BY/GROUP BY emitted a leading comma (syntax error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql.if(false)returnsundefined. SQLite already drops that inWHERE/HAVING, but:leftJoin/innerJoinkept the JOIN and droppedON→ cartesian product (2 rows became 4 in a 2×2 fixture)orderBy/groupBykept an empty list slot →ORDER BY , col/GROUP BY , col(SQLitenear ",": syntax error)This patch skips a non-cross JOIN when
onisundefined(rolling back field/nullability/used-table mutations), and filtersundefinedentries in ORDER BY / GROUP BY (builder + dialect).Test plan
drizzle-orm/tests/sqlite-if-undefined.test.ts(QueryBuildertoSQL)cd integration-tests && pnpm testif Docker is available